Skip to content

Add support for Vega 64#654

Merged
saadrahim merged 1 commit into
ROCm:developfrom
ekuznetsov139:develop
Sep 10, 2019
Merged

Add support for Vega 64#654
saadrahim merged 1 commit into
ROCm:developfrom
ekuznetsov139:develop

Conversation

@ekuznetsov139
Copy link
Copy Markdown
Contributor

Resolves #653

In the long run, a more reliable way of identifying the hardware is needed (why not just go by gfx***?)

@saadrahim
Copy link
Copy Markdown
Member

@amcamd @leekillough This looks like a useful commit with little risk. @yoichiyoshida says a corresponding commit is needed in Tensile as well. Should we do both and close this PR? Seems like a waste of CI cycles to keep this PR open without doing anything.

@ekuznetsov139
Copy link
Copy Markdown
Contributor Author

ekuznetsov139 commented Sep 6, 2019

I guess they are just not used to getting PRs from strangers and they don't know what to do. I have two more PRs against Tensile in the same state (open with no activity for coming up on 3 weeks).

BTW, here are some more Vega 10 device strings not currently recognized by rocBLAS:

Vega 10 [Radeon Instinct MI25]
Radeon PRO V320
Radeon Pro Vega 64
Vega 10 [Radeon PRO WX 8100]
Vega 10 XT [Radeon PRO WX 9100]
Vega 10 XT [Radeon PRO SSG]
Vega 10 XL [Radeon Pro Vega 56]
Vega 10 [Radeon Instinct MI25 MxGPU]

All these names are coming from http://mirrors.kernel.org/ubuntu/pool/main/p/pciutils/pciutils_3.5.2-1ubuntu1.1_i386.deb (the most recent update for 18.04LTS).

If you go to the master version of pci.ids (http://pciids.sourceforge.net/v2.2/pci.ids), you'll see even more, for example, my card (687f) becomes "Vega 10 XL/XT [Radeon RX Vega 56/64]".

If I were an owner of a $10K Radeon Instinct MI25, I'd probably hate to discover that I'm getting fallback performance because my card is not recognized as a legit Vega 10.

Copy link
Copy Markdown
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need corresponding changes in Tensile and additional GPUs need to be added. An AMD engineer will follow up.

Copy link
Copy Markdown
Contributor

@amcamd amcamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Sorry for the delay in merging your work.

@saadrahim saadrahim merged commit 176c728 into ROCm:develop Sep 10, 2019
mlse-lib-jenkins pushed a commit that referenced this pull request Apr 26, 2021
Co-authored-by: Andrew Chapman <andrew.chapman@amd.com>
mlse-lib-jenkins pushed a commit that referenced this pull request Apr 26, 2021
Co-authored-by: amcamd <andrew.chapman@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback operation on RX Vega 64

3 participants