Add gemv_batched and gemv_strided_batched unit tests#645
Merged
Conversation
- Add function templates for gemv_strided_batched and gemv_batched (in rocblas_gemv.hpp) to enable correct calls of these functions from other functions or from outside rocblas. - Add batch and strides checks and quick return in rocblas_gemv_batched.cpp and rocblas_gemv_strided_batched.cpp - Add unit tests testing_gemv_batched.hpp and testing_gemv_strided_batched.hpp - Add new class device_batch_vector in rocblas_vector.hpp. Needed for the batched case. - Add new template headers to rocblas.hpp - Add new template header and especializations for norm_check_general to work with the batched case (in norm.hpp and norm.cpp) - Add new template and espcializations for unit_check_general to work with the batched case (in unit.hpp) - Add new arguments, stride_x and stride_y (needed to test gemv_strided_batched) in rocblas_arguments.hpp and rocblas_common.yaml. Set stride_x and stride_y defaults to zero in rocblas_common.yaml to correctly generate the tests of those functions that do not need these arguments - Include the new tests in client.cpp as well as a description of the new arguments - Add the new functions in rocblas_template.yaml to process YAML from log files - Add batched and strided_batched template test cases in gemv_gtest.cpp - Add new yaml test-data files gemv_batched_gtest.yaml and gemv_strided_batched_gtest.yaml - Include the new yaml files in rocblas_gtest.yaml - Add the new yaml files to the list of dependencies for rocblas_gtest.data in CMakeLists.txt
Contributor
|
There are 770 failed tests: test.txt |
leekillough
suggested changes
Aug 14, 2019
leekillough
approved these changes
Aug 16, 2019
Contributor
leekillough
left a comment
There was a problem hiding this comment.
It passes all tests now, and with Tensile fixed, it builds okay.
mlse-lib-jenkins
pushed a commit
that referenced
this pull request
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable unit tests for gemv_batched and gemv_strided_batched
to enable correct calls of these functions from other functions or from outside rocblas.
- Add batch and strides checks and quick return in rocblas_gemv_batched.cpp and rocblas_gemv_strided_batched.cpp
- Add unit tests testing_gemv_batched.hpp and testing_gemv_strided_batched.hpp
- Add new class device_batch_vector in rocblas_vector.hpp. Needed for the batched case.
- Add new template headers to rocblas.hpp
- Add new template header and especializations for norm_check_general to work with the batched case (in norm.hpp and norm.cpp)
- Add new template and espcializations for unit_check_general to work with the batched case (in unit.hpp)
- Add new arguments, stride_x and stride_y (needed to test gemv_strided_batched) in rocblas_arguments.hpp and rocblas_common.yaml. Set stride_x and stride_y defaults to zero in rocblas_common.yaml to correctly generate the tests of those functions that do not need these arguments
- Include the new tests in client.cpp as well as a description of the new arguments
- Add the new functions in rocblas_template.yaml to process YAML from log files
- Add batched and strided_batched template test cases in gemv_gtest.cpp
- Add new yaml test-data files gemv_batched_gtest.yaml and gemv_strided_batched_gtest.yaml
- Include the new yaml files in rocblas_gtest.yaml
- Add the new yaml files to the list of dependencies for rocblas_gtest.data in CMakeLists.txt