Skip to content

Ablas testing#4

Closed
tingxingdong wants to merge 4 commits into
ROCm:developfrom
tingxingdong:ablas-testing
Closed

Ablas testing#4
tingxingdong wants to merge 4 commits into
ROCm:developfrom
tingxingdong:ablas-testing

Conversation

@tingxingdong
Copy link
Copy Markdown
Contributor

  1. only keep the copyright line and date 2016
  2. clean ablas_types.h.
  3. the implementation of ablas runtime API are put into library/*.cpp
  4. add a dir called testing/ used for both performance benchmarking and correctness validation
    4.1) add a floating point counting .h file (flops.h)
    4.2) add timing, ablas-lapack conversion, random generation, etc utility tools in utility.cpp and .h

hip related definition are in ablas_hip.h now

put the definition in .cpp file in library dir.

add flops (counts).h and utility.cpp(and.h) in testing dir
@tingxingdong
Copy link
Copy Markdown
Contributor Author

Additional comments:

Purpose:

include: ablas API interfaces, ablas data type,
library: BLAS routines' implementations using HIP.
testing: performance benchmarking and validation of ablas routines


Notice:
Code duplication should be avoided.
General functionalities should be implemented once

    Many commonly used functionalities are already in include/, testing/ 
    They include but are no not limited by:
         1)device query
         2)random generator
         3)matrix/vector initilization
         4)timing functions 
         5)ablas types <--> lapack char conversion
         6)flops counts
         ... 

@kknox
Copy link
Copy Markdown

kknox commented Feb 16, 2016

We are going to refactor files and directories first, before we accept this PR

@kknox kknox closed this Feb 16, 2016
@tingxingdong tingxingdong deleted the ablas-testing branch May 2, 2016 20:03
wbgilmartin added a commit that referenced this pull request Oct 21, 2019
* integration of the new tensile client

* New tensile client (#1)

* Refactoring

* Move tensile_host.hpp from public C API to private C++ implementation

* Work around missing complex; fix formatting

* Remove --lib option and argument; make use of legacy handle API instead of introducing a new host handle API

* Map values to value categories currently represented as double

* minor changes

* merge Bill & Lee's changes

* Merge Bill & Lee's changes

* Fix build errors

* Merge 2.10 develop into new tensile client (#2)

* Changed timeout from hours to minutes (#699)

* set clang include directory, fix for centos build error

* hot fix to restore loading of DGEMM replacement kernels (#701)

* SLES support (#704)

* Merging master with SLES commit

* Specifying GPU architecture for ubuntu and sles (#695)

* Fixing Timeout

* BF16 replacement kernels (#705)

* hot fix to restore loading of DGEMM replacement kernels
* Revert "Switch to using separate D for gemm_ex benchmark calls (#667)"
This reverts commit 402d231.
* bf16 kernels for gfx908
* use bf16 UseBeta=0 replacement kernels
* update tensile_tag to use bf16 UseBeta=0 replacement kernels

* Restore usebeta1 logic (#707)

* restore UseBeta=1 logic for arcturus BF16 TN

* Supporting clang10 for SLES (#708)

* Batched syr (#727)

* adding syr batched and strided batched

* rocblas_stride, reusable template pattern work

* WIP

* fixes testing and format

* restore dependency

* adds minimal batches  & bad arg

* fix bad arg testing

* constify ptrs, spelling

* add alpha vector support, PR feedback

* more BF16 TN sizes

* Refactoring

* Move tensile_host.hpp from public C API to private C++ implementation

* Work around missing complex; fix formatting

* Remove --lib option and argument; make use of legacy handle API instead of introducing a new host handle API

* gf908 BF16 TN 512x512x512 known issue

* Enable SLES packaging (#719)

* Refactor Ger and Gemv (#735)

* Map values to value categories currently represented as double

* Rot(m)(g) batched and strided_batched (#737)

* SWDEV 203994 (#743)

* Refactor alpha, beta logging; do not return invalid pointer errors in GEMM, GEMV when other arguments allow early exit

* Fixes

* update

* version for master branch release

* version for develop branch release

* update Tensile package number

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests (#741)

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests

* Missing braces/spelling

* spelling

* Fixing packaging

* New Winograd kernels added (#742)

* fix for changes of FreeIndices change in Tensile

* New tensile client (#3)

* Changed timeout from hours to minutes (#699)

* set clang include directory, fix for centos build error

* hot fix to restore loading of DGEMM replacement kernels (#701)

* SLES support (#704)

* Merging master with SLES commit

* Specifying GPU architecture for ubuntu and sles (#695)

* Fixing Timeout

* BF16 replacement kernels (#705)

* hot fix to restore loading of DGEMM replacement kernels
* Revert "Switch to using separate D for gemm_ex benchmark calls (#667)"
This reverts commit 402d231.
* bf16 kernels for gfx908
* use bf16 UseBeta=0 replacement kernels
* update tensile_tag to use bf16 UseBeta=0 replacement kernels

* Restore usebeta1 logic (#707)

* restore UseBeta=1 logic for arcturus BF16 TN

* Supporting clang10 for SLES (#708)

* Batched syr (#727)

* adding syr batched and strided batched

* rocblas_stride, reusable template pattern work

* WIP

* fixes testing and format

* restore dependency

* adds minimal batches  & bad arg

* fix bad arg testing

* constify ptrs, spelling

* add alpha vector support, PR feedback

* more BF16 TN sizes

* Refactoring

* Move tensile_host.hpp from public C API to private C++ implementation

* Work around missing complex; fix formatting

* Remove --lib option and argument; make use of legacy handle API instead of introducing a new host handle API

* gf908 BF16 TN 512x512x512 known issue

* Enable SLES packaging (#719)

* Refactor Ger and Gemv (#735)

* Map values to value categories currently represented as double

* Rot(m)(g) batched and strided_batched (#737)

* SWDEV 203994 (#743)

* Refactor alpha, beta logging; do not return invalid pointer errors in GEMM, GEMV when other arguments allow early exit

* Fixes

* update

* version for master branch release

* version for develop branch release

* update Tensile package number

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests (#741)

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests

* Missing braces/spelling

* spelling

* Fixing packaging

* New Winograd kernels added (#742)

* Fix GEMM for half type

* updates to get rocblas-test and half sizes to work

* partial fix for NaN test failures

* New tensile client (#4)

* Changed timeout from hours to minutes (#699)

* set clang include directory, fix for centos build error

* hot fix to restore loading of DGEMM replacement kernels (#701)

* SLES support (#704)

* Merging master with SLES commit

* Specifying GPU architecture for ubuntu and sles (#695)

* Fixing Timeout

* BF16 replacement kernels (#705)

* hot fix to restore loading of DGEMM replacement kernels
* Revert "Switch to using separate D for gemm_ex benchmark calls (#667)"
This reverts commit 402d231.
* bf16 kernels for gfx908
* use bf16 UseBeta=0 replacement kernels
* update tensile_tag to use bf16 UseBeta=0 replacement kernels

* Restore usebeta1 logic (#707)

* restore UseBeta=1 logic for arcturus BF16 TN

* Supporting clang10 for SLES (#708)

* Batched syr (#727)

* adding syr batched and strided batched

* rocblas_stride, reusable template pattern work

* WIP

* fixes testing and format

* restore dependency

* adds minimal batches  & bad arg

* fix bad arg testing

* constify ptrs, spelling

* add alpha vector support, PR feedback

* more BF16 TN sizes

* Refactoring

* Move tensile_host.hpp from public C API to private C++ implementation

* Work around missing complex; fix formatting

* Remove --lib option and argument; make use of legacy handle API instead of introducing a new host handle API

* gf908 BF16 TN 512x512x512 known issue

* Enable SLES packaging (#719)

* Refactor Ger and Gemv (#735)

* Map values to value categories currently represented as double

* Rot(m)(g) batched and strided_batched (#737)

* SWDEV 203994 (#743)

* Refactor alpha, beta logging; do not return invalid pointer errors in GEMM, GEMV when other arguments allow early exit

* Fixes

* update

* version for master branch release

* version for develop branch release

* update Tensile package number

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests (#741)

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests

* Missing braces/spelling

* spelling

* Fixing packaging

* New Winograd kernels added (#742)

* Fix GEMM for half type

* Refactoring classes to be simpler

* Fix rocblas_half

* fix negative workgroup mapping error

* fix WorkGroupMapping issue for files in asm_lite

* more fixes for workgroupmapping issue

* wgm issue for asm_miopen

* New tensile client (#5)

* Changed timeout from hours to minutes (#699)

* set clang include directory, fix for centos build error

* hot fix to restore loading of DGEMM replacement kernels (#701)

* SLES support (#704)

* Merging master with SLES commit

* Specifying GPU architecture for ubuntu and sles (#695)

* Fixing Timeout

* BF16 replacement kernels (#705)

* hot fix to restore loading of DGEMM replacement kernels
* Revert "Switch to using separate D for gemm_ex benchmark calls (#667)"
This reverts commit 402d231.
* bf16 kernels for gfx908
* use bf16 UseBeta=0 replacement kernels
* update tensile_tag to use bf16 UseBeta=0 replacement kernels

* Restore usebeta1 logic (#707)

* restore UseBeta=1 logic for arcturus BF16 TN

* Supporting clang10 for SLES (#708)

* Batched syr (#727)

* adding syr batched and strided batched

* rocblas_stride, reusable template pattern work

* WIP

* fixes testing and format

* restore dependency

* adds minimal batches  & bad arg

* fix bad arg testing

* constify ptrs, spelling

* add alpha vector support, PR feedback

* more BF16 TN sizes

* Refactoring

* Move tensile_host.hpp from public C API to private C++ implementation

* Work around missing complex; fix formatting

* Remove --lib option and argument; make use of legacy handle API instead of introducing a new host handle API

* gf908 BF16 TN 512x512x512 known issue

* Enable SLES packaging (#719)

* Refactor Ger and Gemv (#735)

* Map values to value categories currently represented as double

* Rot(m)(g) batched and strided_batched (#737)

* SWDEV 203994 (#743)

* Refactor alpha, beta logging; do not return invalid pointer errors in GEMM, GEMV when other arguments allow early exit

* Fixes

* update

* version for master branch release

* version for develop branch release

* update Tensile package number

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests (#741)

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests

* Missing braces/spelling

* spelling

* Fixing packaging

* New Winograd kernels added (#742)

* Changing Gemv and Ger stride type (#747)

* Handle spaces and newline (#748)

* Fix GEMM for half type

* Tuned Shakespeare kernels (#749)

* Refactoring classes to be simpler

* Fix rocblas_half

* fix argument validation in gemm calls

* fix complex strided batch implementation

* fix validateArgs redefinition

* New tensile client (#6)

* Changed timeout from hours to minutes (#699)

* set clang include directory, fix for centos build error

* hot fix to restore loading of DGEMM replacement kernels (#701)

* SLES support (#704)

* Merging master with SLES commit

* Specifying GPU architecture for ubuntu and sles (#695)

* Fixing Timeout

* BF16 replacement kernels (#705)

* hot fix to restore loading of DGEMM replacement kernels
* Revert "Switch to using separate D for gemm_ex benchmark calls (#667)"
This reverts commit 402d231.
* bf16 kernels for gfx908
* use bf16 UseBeta=0 replacement kernels
* update tensile_tag to use bf16 UseBeta=0 replacement kernels

* Restore usebeta1 logic (#707)

* restore UseBeta=1 logic for arcturus BF16 TN

* Supporting clang10 for SLES (#708)

* Batched syr (#727)

* adding syr batched and strided batched

* rocblas_stride, reusable template pattern work

* WIP

* fixes testing and format

* restore dependency

* adds minimal batches  & bad arg

* fix bad arg testing

* constify ptrs, spelling

* add alpha vector support, PR feedback

* more BF16 TN sizes

* Refactoring

* Move tensile_host.hpp from public C API to private C++ implementation

* Work around missing complex; fix formatting

* Remove --lib option and argument; make use of legacy handle API instead of introducing a new host handle API

* gf908 BF16 TN 512x512x512 known issue

* Enable SLES packaging (#719)

* Refactor Ger and Gemv (#735)

* Map values to value categories currently represented as double

* Rot(m)(g) batched and strided_batched (#737)

* SWDEV 203994 (#743)

* Refactor alpha, beta logging; do not return invalid pointer errors in GEMM, GEMV when other arguments allow early exit

* Fixes

* update

* version for master branch release

* version for develop branch release

* update Tensile package number

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests (#741)

* Fixing SLES tests LD_LIBRARY_PATH and refactoring tests

* Missing braces/spelling

* spelling

* Fixing packaging

* New Winograd kernels added (#742)

* Changing Gemv and Ger stride type (#747)

* Handle spaces and newline (#748)

* Fix GEMM for half type

* Tuned Shakespeare kernels (#749)

* Refactoring classes to be simpler

* Fix rocblas_half

* Cleanup source
zaliu pushed a commit to zaliu/rocBLAS that referenced this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants