Fix CMAKE_INSTALL_PREFIX init behavior on Win32.#1602
Merged
Conversation
marbre
requested review from
NaveenElumalaiAMD,
TorreZuk,
amcamd,
babakpst,
bragadeesh,
daineAMD,
mahmoodw,
rkamd and
yoichiyoshida
as code owners
9 tasks
TorreZuk
approved these changes
May 8, 2025
Contributor
TorreZuk
left a comment
TorreZuk
left a comment
There was a problem hiding this comment.
Windows test failures are unrelated. Looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the guidance at https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html, CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT can be "used by project code to change the default without overriding a user-provided value".
This allows users and integration projects like https://github.com/ROCm/TheRock to set an install path of their choosing while still defaulting to this project's preferred value if the value is not already set. For more context, see ROCm/TheRock#343.