Repository navigation
Adapted fp8 code for compatibility with NCCL 2.24 - #1646
Closed
corey-derochie-amd wants to merge 1 commit into
Closed
corey-derochie-amd wants to merge 1 commit into
corey-derochie-amd wants to merge 1 commit into
Conversation
corey-derochie-amd
requested review from
AbandiGa,
AtlantaPepsi,
BertanDogancay,
JhaShweta1,
Nikhil-Nunna,
PJAvinash,
PedramAlizadeh,
gilbertlee-amd,
haripriyaayyalasomayajula,
isaki001,
jee7s,
mberenjk,
mustafabar,
nileshnegi,
nusislam,
rahulvaidya20,
thananon and
wenkaidu
as code owners
April 16, 2025 19:50
corey-derochie-amd
force-pushed
the
fp8-nccl-sync
branch
from
April 16, 2025 21:08
ed34cab to
5c09f32
Compare
Contributor
Author
|
Will include this in the full NCCL sync PR #1645. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
What were the changes?
Adapted fp8 code for compatibility with NCCL 2.24
Why were the changes made?
To make the NCCL 2.24 sync easier.
How was the outcome achieved?
Reviewed FP8 feature from NCCL 2.24 and made select changes to rccl.
Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.