Repository navigation
Changed default behaviour for RCCL_MSCCLPP_ENABLE based on ENABLE_MSCCLPP definition - #1294
Merged
corey-derochie-amd merged 1 commit intoSep 6, 2024
Conversation
corey-derochie-amd
force-pushed
the
mscclpp-default-enable
branch
from
August 29, 2024 21:49
e273e30 to
3b275c7
Compare
corey-derochie-amd
force-pushed
the
finalize-mscclpp
branch
from
August 29, 2024 23:36
b9e6836 to
60411c2
Compare
corey-derochie-amd
force-pushed
the
mscclpp-default-enable
branch
2 times, most recently
from
September 5, 2024 22:57
195819d to
3239400
Compare
corey-derochie-amd
marked this pull request as ready for review
September 5, 2024 22:58
corey-derochie-amd
requested review from
AtlantaPepsi,
KawtharShafie,
PedramAlizadeh,
akolliasAMD,
edgargabriel,
gilbertlee-amd,
haripriyaayyalasomayajula,
mberenjk,
nileshnegi,
nusislam and
wenkaidu
as code owners
September 5, 2024 22:58
corey-derochie-amd
force-pushed
the
mscclpp-default-enable
branch
2 times, most recently
from
September 5, 2024 23:12
d05bee3 to
2201f18
Compare
corey-derochie-amd
changed the title
RCCL_ENABLE_MSCCLPP based on ENABLE_MSCCLPP definitionRCCL_MSCCLPP_ENABLE based on ENABLE_MSCCLPP definition
…MSCCL. Set `RCCL_MSCCLPP_ENABLE` to 1 by default if `ENABLE_MSCCLPP` is defined, or 0 otherwise. Added a log warning if `RCCL_MSCCLPP_ENABLE` is set to 1 but `ENABLE_MSCCLPP` is not defined.
corey-derochie-amd
force-pushed
the
mscclpp-default-enable
branch
from
September 6, 2024 21:59
2201f18 to
68ea45e
Compare
corey-derochie-amd
added a commit
that referenced
this pull request
Sep 11, 2024
* Added restrictions around calling MSCCL++ collectives (#1281) * Added restriction to non-zero 32-byte multiple message sizes to MSCCL++ AllGather. * Renamed and refactored some mscclpp types. * Only transmit the MSCCL++ unique id for non-split comm init. For splitting comm, it has already been transmitted. Instead, save the MSCCL++ communicator in child communicators when calling `ncclCommSplit`. Only destroy MSCCL++ communicators when no RCCL communicators remain that use it. Also improved trace logging. * Disable MSCCL++ when using managed memory buffers as it isn't supported. * Added datatype and op constraints for MSCCL++ AllReduce. * Added documentation on MSCCL++ restrictions to the README. * [BUILD] Support custom CMake flags in MSCCLPP (#1275) * [BUILD] Support custom CMAKE_PREFIX_PATH in MSCCLPP Signed-off-by: nileshnegi <Nilesh.Negi@amd.com> * [BUILD] CMake flags to support build-id in MSCCLPP Signed-off-by: nileshnegi <Nilesh.Negi@amd.com> * [BUILD] Fix CMake warnings in MSCCLPP build Signed-off-by: nileshnegi <Nilesh.Negi@amd.com> * Wrapped all cmake arguments passed to mscclpp to remove empty arguments and properly format them. --------- Signed-off-by: nileshnegi <Nilesh.Negi@amd.com> Co-authored-by: Corey Derochie <corey.derochie@amd.com> * Link to libmscclpp_nccl statically (#1282) * Switched mscclpp_nccl to static linking. Added a build step to rename the NCCL API functions. * Undid separation of building libmscclpp_nccl from building librccl with MSCCL++ integration. With a static build, it's either fully enabled or fully disabled. * `nm` isn't always available in docker containers due to being stripped down. Removed use of `nm` in `cmake` and hard-coded the output into mscclpp_nccl_syms.txt. * Removed IBVerbs dependency for integrating with MSCCL++ (#1313) * Renamed `RCCL_ENABLE_MSCCLPP` to `RCCL_MSCCLPP_ENABLE` to conform to MSCCL. Set `RCCL_MSCCLPP_ENABLE` to 1 by default if `ENABLE_MSCCLPP` is defined, or 0 otherwise. Added a log warning if `RCCL_MSCCLPP_ENABLE` is set to 1 but `ENABLE_MSCCLPP` is not defined. (#1294) * Include mscclpp as a git submodule (#1314) * Added the desired mscclpp commit as a git submodule. * Added step to automatically checkout the mscclpp submodule if it isn't already present, in case the user forgot to clone recursively. * Added instruction to README to clone using --recurse-submodules to get the mscclpp submodule. * Enabled MSCCL++ feature build. --------- Signed-off-by: nileshnegi <Nilesh.Negi@amd.com> Co-authored-by: Nilesh M Negi <Nilesh.Negi@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
What were the changes?
RCCL_ENABLE_MSCCLPPtoRCCL_MSCCLPP_ENABLE.RCCL_MSCCLPP_ENABLEto 1 by default ifENABLE_MSCCLPPis defined, or 0 otherwise.RCCL_MSCCLPP_ENABLEis set to 1 butENABLE_MSCCLPPis not defined.Why were the changes made?
Approval Checklist
Do not approve until these items are satisfied.