Repository navigation
[ROCm 6.2.0 Cherry-Pick] Consistent channel shuffling for MI300X multi-node - #1263
Closed
nileshnegi wants to merge 1 commit into
Closed
nileshnegi wants to merge 1 commit into
nileshnegi wants to merge 1 commit into
Conversation
nileshnegi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5be3b71.
This reverts commit ad31d93.
(cherry picked from commit a1ef217)
Details
Work item:
Internal
What were the changes?
Revert some commits to ensure channel shuffling for MI300X multi-node as in 0948eec
Why were the changes made?
With newer BKC, multi-node RCCL on RoCE systems performs better with channel shuffling enabled
How was the outcome achieved?
Revert commits 5be3b71 and ad31d93
Approval Checklist
Do not approve until these items are satisfied.