Skip to content

Merge branch upstream/rel-1.23.1 to rocm7.1_internal_testing#184

Closed
apwojcik wants to merge 3 commits into
rocm7.1_internal_testingfrom
rel-1.23.1
Closed

Merge branch upstream/rel-1.23.1 to rocm7.1_internal_testing#184
apwojcik wants to merge 3 commits into
rocm7.1_internal_testingfrom
rel-1.23.1

Merge branch 'rocm7.1_internal_testing' into rel-1.23.1

0dfe783
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / cpplint completed Mar 30, 2026 in 4m 12s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (9917)

include/onnxruntime/core/common/common.h|282| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/common.h|287| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/const_pointer_container.h|53| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/common/eigen_common_wrapper.h|8| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/common/exceptions.h|21| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/common/exceptions.h|22| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/common/exceptions.h|27| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
include/onnxruntime/core/common/gpu_profiler_common.h|6| Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|7| Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|8| Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|9| Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|10| Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|11| Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|12| Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|389| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|439| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|446| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|453| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
include/onnxruntime/core/common/gpu_profiler_common.h|458| "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
include/onnxruntime/core/common/inlined_containers.h|166| Add #include for equal_to<> [build/include_what_you_use] [4]
include/onnxruntime/core/common/logging/capture.h|7| Found C system header after C++ system header. Should be: capture.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/logging/capture.h|97| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/common/logging/isink.h|33| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/common/logging/logging.h|63| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/common/logging/logging.h|113| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/common/logging/macros.h|73| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|80| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|157| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|163| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|169| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|175| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|235| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|241| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|259| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/macros.h|263| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/common/logging/sink_types.h|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
include/onnxruntime/core/common/parse_string.h|88| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/common/parse_string.h|92| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/common/profiler_common.h|8| Found C++ system header after other header. Should be: profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/profiler_common.h|9| Found C++ system header after other header. Should be: profiler_common.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/common/profiler_common.h|36| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/profiler_common.h|37| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/profiler_common.h|51| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/profiler_common.h|52| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/profiler_common.h|71| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/profiler_common.h|72| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/common/profiler_common.h|45| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/common/profiler_common.h|76| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/common/span_utils.h|9| Found C system header after C++ system header. Should be: span_utils.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/eager/ort_kernel_invoker.h|28| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/eager/ort_kernel_invoker.h|49| Add #include for shared_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/allocator.h|100| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/framework/allocator.h|162| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/allocator.h|319| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/allocator.h|257| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/framework/allocator.h|329| Add #include for shared_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/buffer_deleter.h|10| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/buffer_deleter.h|23| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/buffer_deleter.h|15| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/framework/buffer_deleter.h|34| Add #include for unique_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/customregistry.h|46| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/customregistry.h|56| Add #include for shared_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/data_types.h|12| Found C system header after C++ system header. Should be: data_types.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/data_types.h|503| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
include/onnxruntime/core/framework/data_types.h|510| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/data_types.h|593| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
include/onnxruntime/core/framework/data_types.h|668| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
include/onnxruntime/core/framework/data_types.h|729| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/framework/data_types.h|791| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
include/onnxruntime/core/framework/data_types.h|819| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
include/onnxruntime/core/framework/data_types.h|886| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
include/onnxruntime/core/framework/data_types.h|251| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/data_types_internal.h|940| If an else has a brace on one side, it should have it on both [readability/braces] [5]
include/onnxruntime/core/framework/data_types_internal.h|808| Add #include for forward [build/include_what_you_use] [4]
include/onnxruntime/core/framework/data_types_internal.h|968| Add #include for map<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/execution_provider.h|76| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/framework/execution_provider.h|207| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/execution_provider.h|402| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/execution_provider.h|408| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/execution_provider.h|408| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/execution_provider.h|420| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/float16.h|7| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/framework/float16.h|9| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/framework/float16.h|98| Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
include/onnxruntime/core/framework/float16.h|212| Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
include/onnxruntime/core/framework/float16.h|264| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/framework/float16.h|272| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/framework/float16.h|372| Add #include for numeric_limits<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/float4.h|42| Found C system header after C++ system header. Should be: float4.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/float4.h|249| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/float4.h|253| Add #include for numeric_limits<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/float8.h|19| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/framework/float8.h|27| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/framework/float8.h|185| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/framework/float8.h|343| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/framework/float8.h|513| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/framework/float8.h|662| Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
include/onnxruntime/core/framework/float8.h|875| Add #include for numeric_limits<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/framework_common.h|9| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/framework/framework_provider_common.h|8| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/framework_provider_common.h|9| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/func_api.h|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
include/onnxruntime/core/framework/func_api.h|3| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/int4.h|9| Found C system header after other header. Should be: int4.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/int4.h|150| Add #include for pair<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/kernel_def_builder.h|21| Add #include for map<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/kernel_def_builder.h|353| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/framework/kernel_registry.h|15| Add #include for multimap<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/kernel_registry.h|16| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/kernel_registry.h|126| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel.h|29| Found C system header after other header. Should be: op_kernel.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/op_kernel.h|103| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel.h|160| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel.h|372| Add #include for unique_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel.h|414| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel_context.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_FRAMEWORK_OP_KERNEL_CONTEXT_H_ [build/header_guard] [5]
include/onnxruntime/core/framework/op_kernel_context.h|13| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel_context.h|68| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel_context.h|169| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_kernel_info.h|11| Found C system header after other header. Should be: op_kernel_info.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/op_kernel_info.h|65| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_node_proto_helper.h|10| Found C system header after other header. Should be: op_node_proto_helper.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/op_node_proto_helper.h|109| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/op_node_proto_helper.h|157| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/ort_value.h|41| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/framework/ort_value.h|79| Add #include for shared_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/ortdevice.h|117| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/ortmemoryinfo.h|23| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/framework/ortmemoryinfo.h|50| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/provider_options_utils.h|53| Add #include for pair<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/provider_options_utils.h|197| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/resource_accountant.h|6| is an unapproved C++17 header. [build/c++17] [5]
include/onnxruntime/core/framework/resource_accountant.h|41| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/framework/resource_accountant.h|96| Add #include for max [build/include_what_you_use] [4]
include/onnxruntime/core/framework/resource_accountant.h|126| Add #include for unique_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/sparse_tensor.h|121| Add #include for shared_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/sparse_tensor.h|210| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/framework/sparse_tensor.h|527| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/stream_handles.h|39| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/stream_handles.h|42| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/stream_handles.h|47| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/stream_handles.h|100| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/stream_handles.h|149| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/stream_handles.h|185| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/stream_handles.h|192| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/framework/stream_handles.h|37| Add #include for unique_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/framework/tensor.h|12| Found C system header after C++ system header. Should be: tensor.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/tensor.h|17| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/framework/tensor.h|25| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/framework/tensor_shape.h|12| Found C system header after C++ system header. Should be: tensor_shape.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/framework/tensor_shape.h|15| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/framework/tensor_shape.h|59| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/framework/tensor_shape.h|60| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/framework/tensor_shape.h|56| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/framework/tensor_shape.h|168| Add #include for unique_ptr<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/basic_types.h|39| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/graph/graph.h|6| is an unapproved C++17 header. [build/c++17] [5]
include/onnxruntime/core/graph/graph.h|18| Found C system header after other header. Should be: graph.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/graph/graph.h|478| Add #include for map<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/graph.h|560| Add #include for set<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/graph.h|1707| Add #include for pair<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/graph.h|1951| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/graph_nodes.h|167| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/graph/graph_nodes.h|174| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/graph/graph_nodes.h|179| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/graph/graph_viewer.h|6| is an unapproved C++17 header. [build/c++17] [5]
include/onnxruntime/core/graph/graph_viewer.h|142| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/graph_viewer.h|203| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/graph/graph_viewer.h|237| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/indexed_sub_graph.h|66| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/graph/node_arg.h|116| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/graph/node_arg.h|126| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/graph/onnx_protobuf.h|5| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/graph/schema_registry.h|32| Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/schema_registry.h|43| Add #include for numeric_limits<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/schema_registry.h|84| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/graph/schema_registry.h|150| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/optimizer/graph_transformer_config.h|52| Complex multi-line /.../-style comment found. Lint may give bogus warnings. Consider replacing these with //-style comments, with #if 0...#endif, or with more clearly structured multi-line comments. [readability/multiline_comment] [5]
include/onnxruntime/core/optimizer/rewrite_rule.h|50| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/optimizer/rewrite_rule.h|62| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/optimizer/rewrite_rule.h|76| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/optimizer/rule_based_graph_transformer.h|74| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/platform/Barrier.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PLATFORM_BARRIER_H_ [build/header_guard] [5]
include/onnxruntime/core/platform/Barrier.h|14| Found C++ system header after other header. Should be: Barrier.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/platform/Barrier.h|15| Found C++ system header after other header. Should be: Barrier.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/platform/Barrier.h|16| Found C++ system header after other header. Should be: Barrier.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/platform/Barrier.h|79| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/platform/EigenNonBlockingThreadPool.h|15| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/platform/EigenNonBlockingThreadPool.h|622| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
include/onnxruntime/core/platform/EigenNonBlockingThreadPool.h|704| Using C-style cast. Use reinterpret_cast<ThreadPoolTempl*>(...) instead [readability/casting] [4]
include/onnxruntime/core/platform/EigenNonBlockingThreadPool.h|736| Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
include/onnxruntime/core/platform/EigenNonBlockingThreadPool.h|292| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/platform/EigenNonBlockingThreadPool.h|728| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/platform/EigenNonBlockingThreadPool.h|1272| Add #include for move [build/include_what_you_use] [4]
include/onnxruntime/core/platform/ort_spin_lock.h|5| Found C++ system header after other header. Should be: ort_spin_lock.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/platform/threadpool.h|26| "functional" already included at include/onnxruntime/core/platform/threadpool.h:21 [build/include] [4]
include/onnxruntime/core/platform/threadpool.h|27| "memory" already included at include/onnxruntime/core/platform/threadpool.h:22 [build/include] [4]
include/onnxruntime/core/platform/threadpool.h|300| Add #include for min [build/include_what_you_use] [4]
include/onnxruntime/core/providers/acl/acl_provider_factory.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_ACL_ACL_PROVIDER_FACTORY_H_ [build/header_guard] [5]
include/onnxruntime/core/providers/acl/acl_provider_factory.h|5| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/armnn/armnn_provider_factory.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_ARMNN_ARMNN_PROVIDER_FACTORY_H_ [build/header_guard] [5]
include/onnxruntime/core/providers/armnn/armnn_provider_factory.h|4| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/cann/cann_provider_options.h|9| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/coreml/coreml_provider_factory.h|5| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/cpu/cpu_provider_factory.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_CPU_CPU_PROVIDER_FACTORY_H_ [build/header_guard] [5]
include/onnxruntime/core/providers/cpu/cpu_provider_factory.h|4| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/cuda/cuda_provider_options.h|9| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/cuda/cuda_resource.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_CUDA_CUDA_RESOURCE_H_ [build/header_guard] [5]
include/onnxruntime/core/providers/custom_op_context.h|9| You don't need a ; after a } [readability/braces] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|27| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|43| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|44| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|45| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|46| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|47| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|48| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
include/onnxruntime/core/providers/dml/dml_provider_factory.h|49| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
include/onnxruntime/core/providers/nnapi/nnapi_provider_factory.h|5| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_options.h|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
include/onnxruntime/core/providers/openvino/openvino_provider_factory.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_OPENVINO_OPENVINO_PROVIDER_FACTORY_H_ [build/header_guard] [5]
include/onnxruntime/core/providers/openvino/openvino_provider_factory.h|4| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/openvino/openvino_provider_factory.h|8| Add #include for string [build/include_what_you_use] [4]
include/onnxruntime/core/providers/openvino/openvino_provider_factory.h|8| Add #include for vector<> [build/include_what_you_use] [4]
include/onnxruntime/core/providers/rknpu/rknpu_provider_factory.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_RKNPU_RKNPU_PROVIDER_FACTORY_H_ [build/header_guard] [5]
include/onnxruntime/core/providers/rknpu/rknpu_provider_factory.h|3| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/rocm/rocm_context.h|| No #ifndef header guard found, suggested CPP variable is: INCLUDE_ONNXRUNTIME_CORE_PROVIDERS_ROCM_ROCM_CONTEXT_H_ [build/header_guard] [5]
include/onnxruntime/core/providers/rocm/rocm_context.h|6| Include the directory when naming header files [build/include_subdir] [4]
include/onnxruntime/core/providers/rocm/rocm_context.h|8| Found C system header after other header. Should be: rocm_context.h, c system, c++ system, other. [build/include_order] [4]
include/onnxruntime/core/providers/rocm/rocm_context.h|9| Found C system header after other header. Should be: rocm_context.h, c system, c++ system, other. [build/include_order] [4]
... (Too many findings. Dropped some findings)

Filtered Findings (0)

Annotations

Check notice on line 282 in include/onnxruntime/core/common/common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/common.h#L282

 Use int16_t/int64_t/etc, rather than the C type long  [runtime/int] [4]
Raw output
include/onnxruntime/core/common/common.h:282:  Use int16_t/int64_t/etc, rather than the C type long  [runtime/int] [4]

Check notice on line 287 in include/onnxruntime/core/common/common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/common.h#L287

 Use int16_t/int64_t/etc, rather than the C type long  [runtime/int] [4]
Raw output
include/onnxruntime/core/common/common.h:287:  Use int16_t/int64_t/etc, rather than the C type long  [runtime/int] [4]

Check notice on line 53 in include/onnxruntime/core/common/const_pointer_container.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/const_pointer_container.h#L53

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/core/common/const_pointer_container.h:53:  You don't need a ; after a }  [readability/braces] [4]

Check notice on line 8 in include/onnxruntime/core/common/eigen_common_wrapper.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/eigen_common_wrapper.h#L8

 Include the directory when naming header files  [build/include_subdir] [4]
Raw output
include/onnxruntime/core/common/eigen_common_wrapper.h:8:  Include the directory when naming header files  [build/include_subdir] [4]

Check notice on line 21 in include/onnxruntime/core/common/exceptions.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/exceptions.h#L21

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/core/common/exceptions.h:21:  You don't need a ; after a }  [readability/braces] [4]

Check notice on line 22 in include/onnxruntime/core/common/exceptions.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/exceptions.h#L22

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/core/common/exceptions.h:22:  You don't need a ; after a }  [readability/braces] [4]

Check notice on line 27 in include/onnxruntime/core/common/exceptions.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/exceptions.h#L27

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/core/common/exceptions.h:27:  You don't need a ; after a }  [readability/braces] [4]

Check notice on line 0 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h

 No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]

Check notice on line 6 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L6

 Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:6:  Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 7 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L7

 Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:7:  Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 8 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L8

 Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:8:  Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 9 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L9

 Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:9:  Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 10 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L10

 Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:10:  Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 11 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L11

 Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:11:  Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 12 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L12

 Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:12:  Found C++ system header after other header. Should be: gpu_profiler_common.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 389 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L389

 Use int16_t/int64_t/etc, rather than the C type long  [runtime/int] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:389:  Use int16_t/int64_t/etc, rather than the C type long  [runtime/int] [4]

Check notice on line 439 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L439

 "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:439:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]

Check notice on line 446 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L446

 "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:446:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]

Check notice on line 453 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L453

 "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:453:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]

Check notice on line 458 in include/onnxruntime/core/common/gpu_profiler_common.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/gpu_profiler_common.h#L458

 "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
Raw output
include/onnxruntime/core/common/gpu_profiler_common.h:458:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]

Check notice on line 166 in include/onnxruntime/core/common/inlined_containers.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/inlined_containers.h#L166

 Add #include <functional> for equal_to<>  [build/include_what_you_use] [4]
Raw output
include/onnxruntime/core/common/inlined_containers.h:166:  Add #include <functional> for equal_to<>  [build/include_what_you_use] [4]

Check notice on line 7 in include/onnxruntime/core/common/logging/capture.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/logging/capture.h#L7

 Found C system header after C++ system header. Should be: capture.h, c system, c++ system, other.  [build/include_order] [4]
Raw output
include/onnxruntime/core/common/logging/capture.h:7:  Found C system header after C++ system header. Should be: capture.h, c system, c++ system, other.  [build/include_order] [4]

Check notice on line 97 in include/onnxruntime/core/common/logging/capture.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/logging/capture.h#L97

 Add #include <string> for string  [build/include_what_you_use] [4]
Raw output
include/onnxruntime/core/common/logging/capture.h:97:  Add #include <string> for string  [build/include_what_you_use] [4]

Check notice on line 33 in include/onnxruntime/core/common/logging/isink.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/logging/isink.h#L33

 You don't need a ; after a }  [readability/braces] [4]
Raw output
include/onnxruntime/core/common/logging/isink.h:33:  You don't need a ; after a }  [readability/braces] [4]

Check notice on line 63 in include/onnxruntime/core/common/logging/logging.h

See this annotation in the file changed.

@github-actions github-actions / cpplint

[cpplint] include/onnxruntime/core/common/logging/logging.h#L63

 Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
Raw output
include/onnxruntime/core/common/logging/logging.h:63:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]