Repository navigation
perf(umbp): give ranged get/put separate scratch arenas - #581
Merged
isytwu merged 1 commit intoAug 19, 2026
Merged
Conversation
Remote BatchGetRanges and BatchPutRanges shared one scratch arena and a single mutex held across the whole network round-trip, so a remote ranged get and put serialized against each other. Allocate a separate RDMA- registered arena and mutex per direction (DistributedClient owns both, each sized by ranged_scratch_size) so load/offload overlap instead of blocking: mixed remote get+put throughput improves ~60% at 4-8 threads; same-direction behavior is unchanged. Also adds concurrency correctness tests: a separate-arena remote put-then-get round-trip and a concurrent get/put no-clobber check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
TianDi101
pushed a commit
that referenced
this pull request
Sep 3, 2026
Remote BatchGetRanges and BatchPutRanges shared one scratch arena and a single mutex held across the whole network round-trip, so a remote ranged get and put serialized against each other. Allocate a separate RDMA- registered arena and mutex per direction (DistributedClient owns both, each sized by ranged_scratch_size) so load/offload overlap instead of blocking: mixed remote get+put throughput improves ~60% at 4-8 threads; same-direction behavior is unchanged. Also adds concurrency correctness tests: a separate-arena remote put-then-get round-trip and a concurrent get/put no-clobber check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remote
BatchGetRangesandBatchPutRangesshared one scratch arena and asingle mutex held across the whole network round-trip, so a remote ranged get
and put serialized against each other.
This gives each direction its own RDMA-registered arena and mutex:
DistributedClientallocates a GET arena and a PUT arena (each sized byranged_scratch_size) and registers both.PoolClientConfigcarriesranged_get_scratch_*/ranged_put_scratch_*;BatchGetRanges/BatchPutRangeseach take their own arena + mutex.A remote ranged get and put now overlap; two same-direction ops still
serialize on that direction's mutex (unchanged).
Results (in-process 2-node bench, mlx5 RoCE, mixed remote get+put)
Tests
test_umbp_pool_client_ranges(7/7): addsSplitRemotePutThenGetRoundTripsand
SplitConcurrentGetPutDoNotClobber(concurrent get/put, byte-for-byteverify).
cross_node_smoke/pool_client_batch_put/medium_selectionstill pass.
🤖 Generated with Claude Code