[Comgr] Add missing clangOptions to Comgr link libraries#626
[Comgr] Add missing clangOptions to Comgr link libraries#626jmmartinez merged 1 commit intoamd-stagingfrom
Conversation
Fixes error: /usr/bin/ld: tools/comgr/CMakeFiles/amd_comgr.dir/src/comgr-compiler.cpp.o: in function `COMGR::AMDGPUCompiler::executeInProcessDriver(llvm::ArrayRef<char const*>)': amd/comgr/src/comgr-compiler.cpp:739: undefined reference to `clang::getDriverOptTable()' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed.
lamb-j
left a comment
There was a problem hiding this comment.
Thanks for catching this. We should try to make sure this patch makes it into the next promotion to TheRock, as I believe they're using -DBUILD_SHARED_LIBS=ON
Do you know how do we do that ? (e.g. is there a CP list) |
|
Good question. Right now TheRock hashes are coming from our amd-mainline branch, so saftest bet would be to CP this one to mainline. Will this break anything if we don't also pull in llvm#167374? |
Yes, it'd be broken since |
Fixes error when compiling with
-DBUILD_SHARED_LIBS=ON:Related to llvm#167374