Enable Lintian Support hipcc #445
Open
+156
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amd/hipcc/utils.cmake
Outdated
| ) | ||
|
|
||
| if( BUILD_ENABLE_LINTIAN_OVERRIDES ) | ||
| if(NOT ${BUILD_SHARED_LIBS}) |
There was a problem hiding this comment.
I don't think we need this section. We do not have a build version of HIPCC with shared libraries, nor asan.
amd/hipcc/utils.cmake
Outdated
| COMPONENT ${COMPONENT_NAME_T}) | ||
| endif() | ||
|
|
||
| else() |
There was a problem hiding this comment.
So I think this is the other case for the "if (DEBIAN)" statement, so this is for RPMs. But I think this a duplicate "install" command to what we have at line (around llvm#175) of the CMakeLists.txt file.
…ons in utils.cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function configure_pkg to install changelog, copyright, and lintian override for debian.
Install changelog, copyright, and lintian override files to fix lintian errors:
no-copyright-file
debian-changelog-file-missing
dir-or-file-in-opt