Reapply "[HIP][Clang] Remove __AMDGCN_WAVEFRONT_SIZE macros" (#164217)#434
Merged
kzhuravl merged 1 commit intoamd-mainlinefrom Oct 31, 2025
Merged
Conversation
…4217) This reverts commit 78bf682. Original PR: llvm#157463 Revert PR: llvm#158566 The relevant buildbots have been updated to a ROCm version that does not use the macros anymore to avoid the failures. Implements SWDEV-522062. (cherry picked from commit ea03447)
Collaborator
Author
|
!PSDB |
Collaborator
Author
|
The GitHub UI tells me that merging is blocked because I'm not authorized to push to this branch. Can one of you merge it, @saipoorna or @kzhuravl ? |
Collaborator
Done, those permission issues should be fixed soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 78bf682.
Original PR: llvm#157463
Revert PR: llvm#158566
The relevant buildbots have been updated to a ROCm version that does not use the macros anymore to avoid the failures.
Implements SWDEV-522062.
(cherry picked from commit ea03447)