add node_selector_enabled variable #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #29 @y2kenny
Default behaviour before: there would be no nodeselectors applied because nfd.enabled is false by default. If you set nfd.enabled=true, then you would get both an installation of NFD, and application of nodeselectors on the daemonsets.
Default behaviour after: there would be no nodeselectors applied because node_selector_enabled is false by default. Installation of NFD and application of nodeselectors can be controlled separately and independently.
Anyone who previously set nfd.enabled=true and got both a NFD installation and nodeselectors will now need to also set node_selector_enabled=true to continue applying the same nodeselector as before.
It's a bit weird but seems like a less disruptive way to un-overload the nfd.enabled variable.