Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update broken link to ROCM docs in readme file #47

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Update broken link to ROCM docs in readme file #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36fc289
Upgrade go version to 1.21
y2kenny-amd Jan 12, 2024
e9ecf95
Update README.md
maarten-blokker Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM docker.io/golang:1.19.13-alpine3.18
FROM docker.io/golang:1.21.6-alpine3.19
RUN apk --no-cache add git pkgconfig build-base libdrm-dev
RUN apk --no-cache add hwloc-dev --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community
RUN mkdir -p /go/src/github.com/RadeonOpenCompute/k8s-device-plugin
Expand All @@ -20,7 +20,7 @@ WORKDIR /go/src/github.com/RadeonOpenCompute/k8s-device-plugin/cmd/k8s-device-pl
RUN go install \
-ldflags="-X main.gitDescribe=$(git -C /go/src/github.com/RadeonOpenCompute/k8s-device-plugin/ describe --always --long --dirty)"

FROM alpine:3.18.4
FROM alpine:3.19.0
LABEL \
org.opencontainers.image.source="https://github.com/RadeonOpenCompute/k8s-device-plugin" \
org.opencontainers.image.authors="Kenny Ho <[email protected]>" \
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ $ kubectl create -f https://raw.githubusercontent.com/RadeonOpenCompute/k8s-devi
[ds]: https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/
[dp]: https://kubernetes.io/docs/concepts/cluster-administration/device-plugins/
[helmamdgpu]: https://artifacthub.io/packages/helm/amd-gpu-helm/amd-gpu
[rocm]: https://docs.amd.com/en/latest/rocm.html
[rocm]: https://docs.amd.com/en/latest/what-is-rocm.html
[rock]: https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver
[rocminstall]: https://docs.amd.com/en/latest/deploy/linux/quick_start.html
[amdgpuinstall]: https://amdgpu-install.readthedocs.io/en/latest/
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/RadeonOpenCompute/k8s-device-plugin

go 1.19
go 1.21

require (
github.com/go-logr/logr v1.2.3
Expand Down
4 changes: 2 additions & 2 deletions labeller.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM docker.io/golang:1.19.13-alpine3.18
FROM docker.io/golang:1.21.6-alpine3.19
RUN apk --no-cache add git pkgconfig build-base libdrm-dev
RUN mkdir -p /go/src/github.com/RadeonOpenCompute/k8s-device-plugin
ADD . /go/src/github.com/RadeonOpenCompute/k8s-device-plugin
WORKDIR /go/src/github.com/RadeonOpenCompute/k8s-device-plugin/cmd/k8s-node-labeller
RUN go install \
-ldflags="-X main.gitDescribe=$(git -C /go/src/github.com/RadeonOpenCompute/k8s-device-plugin/ describe --always --long --dirty)"

FROM alpine:3.18.4
FROM alpine:3.19.0
LABEL \
org.opencontainers.image.source="https://github.com/RadeonOpenCompute/k8s-device-plugin" \
org.opencontainers.image.authors="Kenny Ho <[email protected]>" \
Expand Down