Repository navigation
Declare hipDataType arguments integer(c_int) in the _typed forms - #609
Merged
Merged
Conversation
The _typed forms of hipSOLVER (8) and hipSPARSE (25) declared their hipDataType arguments integer(kind(HIP_R_32F)), while the bind(C) interfaces of the same generics declare them integer(c_int). Both are the C int kind, so callers see no change; the 33 forms no longer need a `use hipfort_enums`. Regenerated with rocm-fortran 602a86b, symbol tests included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_typedforms of hipSOLVER (8) and hipSPARSE (25) declared theirhipDataTypeargumentsinteger(kind(HIP_R_32F)), while thebind(C)interfaces of the same generics declare theminteger(c_int)since #586.They now use
integer(c_int)too.intkind (anenum, bind(c)is interoperable withint), so callers see no change: passingHIP_R_32For aninteger(c_int)variable compiles and behaves as before.use hipfort_enums, and the symbol tests of the two libraries drop it as well.