Repository navigation
Update hip, hipBLAS and rocBLAS bindings - #572
Merged
Merged
Conversation
amontoison
added a commit
that referenced
this pull request
Oct 6, 2026
The symbol tests were last regenerated before #553, #564, #571, #572 and 5de6093, so they no longer matched the bindings: eight of them failed to compile with -DHIPFORT_EXTENDED_TESTS=ON, passing type(c_ptr) to arguments those changes typed (hipblasGetProperty_, hipsolver *gels niters, the hipSPARSE/rocSPARSE descriptor getters, rocfft_cache_serialize, the hipFFTW guru dims, ...). Regenerated with gen_symbol_tests.jl from rocm-fortran main, against the bindings on develop. Besides the signature fixes, the tests now reference the routines added by the ROCm 10.1 regeneration (rocsolver cholqr and larft_64, rocblas gemm_grouped_batched, ...). Most of the remaining churn is the scratch variables being renumbered around the new types. Built with gfortran against ROCm 10.1 with -DHIPFORT_EXTENDED_TESTS=ON: all 13 symbol tests compile, link and pass, and the full ctest run shows only the three known WSL failures (hip_mem_advise f2003/f2008, hip_module_kernel).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.