Repository navigation
Add a uniform MIT/SPDX license header across the repository - #563
Merged
Merged
Conversation
amontoison
force-pushed
the
update_license
branch
from
September 30, 2026 00:02
21b5ce1 to
eefd794
Compare
hipfort carried three different header variants and left most of its files with none at all. Every source and build file now opens with the same MIT notice, and that notice carries an SPDX-License-Identifier line so automated license scanners can pick it up. LICENSE and the README section follow the same wording, so [MITx11 License] is gone from the repository. Copyright years are not normalized. A file that already had a header keeps its own span, and a file that gains one is dated from its git history, so no file claims a year it does not have. The 13 generated symbol tests carried a second, shorter banner of their own below the new header; it is dropped here. gen_symbol_tests.jl in rocm-fortran still needs the matching change, or a regeneration will bring it back. The two cmake/Modules/Set*.cmake files are vendored from SethMMorton/cmake_fortran_template (MIT, (c) 2018 Seth M. Morton). Stamping an AMD copyright on them would be a misattribution, so they are left untouched. Documentation is out of scope.
amontoison
force-pushed
the
update_license
branch
from
September 30, 2026 00:06
eefd794 to
d5604a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the SPDX review comment on ROCm/rocm-systems#11923.
1074 files. No line of code is added or removed — the only non-comment lines that change are the prose in
README.mdandLICENSE.What
hipfort carried three different header variants and left most of its files with none at all. Every source and build file now opens with the same MIT notice, taken from
rocsparse.f90, plus anSPDX-License-Identifier: MITline so automated license scanners pick it up. Comment style follows the language:!for Fortran,#for CMake/shell/Python,//for C++.LICENSEand the README license section were reworded to match, so[MITx11 License]no longer appears anywhere in the repository.Copyright years are preserved, not normalized
A file that already had a header keeps its own span (
2020-2022,2024-2026, …). A file that gains one is dated from its git history. No file claims a year it does not have.Generated symbol tests
The 13
test_*.F03symbol tests carried a second, shorter banner of their own below the new header, which re-introduced[MITx11 License]. It is dropped here, along with theAUTO-GENERATEDmarker line.Those files come from
gen_symbol_tests.jlin rocm-fortran, which has been updated to emit the standard header instead, so a regeneration no longer brings the old banner back.Deliberately left untouched
cmake/Modules/SetCompileFlag.cmakeandcmake/Modules/SetFortranFlags.cmakeare vendored from SethMMorton/cmake_fortran_template, which is MIT (c) 2018 Seth M. Morton. Stamping an AMD copyright on them would be a misattribution.Documentation (
.md,.rst, Doxyfile) and config files (.gitignore,.yml,requirements.*) are out of scope.Checks
test/check_line_length.sh).SPDX-License-Identifier, except the two vendored ones above.