Repository navigation
SWDEV-516659 - Ensure the list of recommended and suggested packages are comma separated - #368
Conversation
…are comma separated A list in cmake is a semicolon(;) separated group of strings. The cpack recommends and suggests variables should have comma separated list, otherwise it will result in package installation failure.
|
We need to CP to 6.4 also |
|
I may be stepping on a land mine by asking this, but CMake 3.12 added a more idiomatic way to do this https://cmake.org/cmake/help/latest/command/list.html#join
We would have to bump the minimum version to use it, but I can see that rocBLAS targets 3.16, and I believe the cmake version shipped with the OSes we support is much higher than that. |
Since the current cmake version is set to 3.7 didn't use cmake list(JOIN ..) in this patch. Also this need to be cherry-picked to 6.4 release branch. |
cgmb
left a comment
cgmb
left a comment
There was a problem hiding this comment.
IMO, you might as well just directly set the *_RECOMMENDS and *_SUGGESTS with the string command, rather than using list and then string. With that said, I can live with it as-is if you just want to merge something that you've tested ASAP. It's not like the rest of our CMake is beautiful anyway.
#364 is related and is also desired for a cherry-pick, once reviewed and approved.
Sure. Bumping the minimum requirement for hipSOLVER to CMake 3.12 is fine. The rocSOLVER library requires 3.13, and rocBLAS requires 3.16. |
|
Can we proceed to merge this PR and put in "staging" branch for further CQE cycle? |
A list in cmake is a semicolon(;) separated group of strings. The cpack recommends and suggests variables should have comma separated list, otherwise it will result in package installation failure.