Fix CMAKE_INSTALL_PREFIX init behavior on Win32.#129
Merged
Conversation
ScottTodd
requested review from
af-ayala,
eng-flavio-teixeira,
evetsso,
feizheng10 and
malcolmroberts
as code owners
9 tasks
evetsso
approved these changes
Apr 9, 2025
Member
Author
|
Thanks for approving! Should I merge this myself with squash and merge, or do you want to do that yourself? https://github.com/ROCm/hipFFT/blob/develop/.github/CONTRIBUTING.md#process |
Contributor
|
We'll merge this but we've got a couple of other internal tasks to take care of first. |
eng-flavio-teixeira
approved these changes
Apr 16, 2025
malcolmroberts
approved these changes
Apr 16, 2025
Kevonosdiaz
approved these changes
Apr 16, 2025
af-ayala
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the guidance at https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html,
CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULTcan be "used by project code to change the default without overriding a user-provided value".This allows users and integration projects like https://github.com/ROCm/TheRock to set an install path of their choosing while still defaulting to this project's preferred value if the value is not already set. For more context, see ROCm/TheRock#340.