HIP SDK spaces support, plus previous benchmark fixes#225
Merged
Conversation
stanleytsang-amd
requested review from
Maetveis,
nolmoonen and
vince-streamhpc
doctorcolinsmith
approved these changes
Jan 3, 2023
stanleytsang-amd
added a commit
that referenced
this pull request
Jan 4, 2023
* HIP SDK spaces support, plus previous benchmark fixes * Better fix for Windows * Update cmake_path function for rmake.py * Update copyright
stanleytsang-amd
added a commit
that referenced
this pull request
Jan 9, 2023
lawruble13
added a commit
that referenced
this pull request
Mar 6, 2023
* HIP SDK spaces support, plus previous benchmark fixes (#225) * HIP SDK spaces support, plus previous benchmark fixes * Better fix for Windows * Update cmake_path function for rmake.py * Update copyright * Fix toolchain-windows.cmake for HIP SDK (#227) * HIP SDK spaces support, plus previous benchmark fixes * Better fix for Windows * Update cmake_path function for rmake.py * Update copyright * Cleanup toolchain-windows.cmake, compatibility with HIP SDK * Take python3 by default * Fix out of bounds access in test (#230) * fix invalid seed_value computation * Merge branch '156-test_hipcub_block_run_length_decode-cpp-out-of-bounds-memory-access' into 'develop_stream' Resolve "test_hipcub_block_run_length_decode.cpp out of bounds memory access" Closes #156 See merge request amd/libraries/hipCUB!138 --------- Co-authored-by: Robin Voetter <robin@streamhpc.com> * Restore test executables in tests package (#231) * Fix missing copyright header (#232) * Make googlebenchmark not a shared library anymore (#233) * Update changelog for 5.5 cherry picks --------- Co-authored-by: Nol Moonen <nolmoonen@hotmail.nl> Co-authored-by: Robin Voetter <robin@streamhpc.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Cory Bloor <Cordell.Bloor@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* HIP SDK spaces support, plus previous benchmark fixes * Better fix for Windows * Update cmake_path function for rmake.py * Update copyright [ROCm/hipCUB commit: 0e1ada7]
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we did not account for spaces in the HIP installation path in Windows (ie. C:\Program Files, etc). This fixes that (we'll also have to roll out the fix for the other libraries). Also includes windows-specific fixes for the hipCUB benchmarks on Windows from #197