Repository navigation
Support <F8,B,S>, <F8B8,B,S> with BiasB for type TN - #522
Merged
Merged
Conversation
solaslin
force-pushed
the
add-new-fp8-type-api
branch
from
December 28, 2023 02:57
08f6292 to
2beae93
Compare
solaslin
force-pushed
the
add-new-fp8-type-api
branch
from
December 28, 2023 06:23
763c72a to
e7f30ec
Compare
solaslin
commented
Dec 28, 2023
Comment on lines
93
to
99
|
|
||
| Real precisions 1 bytes dst bf16: &real_precisions_1b_dst_bf16 | ||
| - *f8_precision_dst_bf16 | ||
| - *f8bf8_precision_dst_bf16 | ||
| # - *bf8f8_precision_dst_bf16 # TODO | ||
|
|
||
| Real precisions 1 bytes dst fp8: &real_precisions_1b_dst_f8 |
Contributor
Author
There was a problem hiding this comment.
the third one is not included in this pr but we are gonna support it later. so this is just a placeholder
solaslin
commented
Dec 28, 2023
Comment on lines
131
to
133
| if (CMAKE_BUILD_TYPE MATCHES "Debug" AND NOT WIN32) | ||
| set (CMAKE_CXX_FLAGS_DEBUG "-O1 ${CMAKE_CXX_FLAGS_DEBUG} -gsplit-dwarf -ggdb" ) | ||
| set (CMAKE_CXX_FLAGS_DEBUG "-O0 ${CMAKE_CXX_FLAGS_DEBUG} -gsplit-dwarf -ggdb" ) | ||
| endif() |
Contributor
Author
There was a problem hiding this comment.
-O0 can get more detailed info when debugging
solaslin
commented
Dec 28, 2023
Comment on lines
116
to
118
| HIPBLASLT_COMPUTE_F32_FAST_XF32 = 301, /**< XF32 compute for 32-bit input and output matrices */ | ||
| HIPBLASLT_COMPUTE_F64 = 302, /**<32-bit floating-point precision.*/ | ||
| HIPBLASLT_COMPUTE_F64 = 302, /**<64-bit floating-point precision.*/ | ||
| HIPBLASLT_COMPUTE_I32 = 303, |
solaslin
commented
Dec 28, 2023
solaslin
marked this pull request as ready for review
December 28, 2023 06:29
solaslin
requested review from
KKyang,
aazz44ss,
imcarsonliao,
jichangjichang and
vin-huang
as code owners
December 28, 2023 06:29
KKyang
approved these changes
Jan 4, 2024
assistant-librarian Bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
[hipblaslt] Adjust HIPBLASLT_TENSILE_LIBRARY_DIR on Windows. (#522) This gets hipBLASLt tests passing on Windows in TheRock (see ROCm/TheRock#783), for ROCm/TheRock#681. It also enables PyTorch builds on Windows to use hipBLASLt without needing to manually copy folders around in the install directory. This directory structure is now consistent with rocBLAS: https://github.com/ROCm/rocm-libraries/blob/c7fe831061a4cdc3a14e1aacab8c0738c21daf32/projects/rocblas/library/src/CMakeLists.txt#L825-L830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves basic requirement SWDEV-436059
A_type=fp8 B_type=fp8 D_type=bf16 transa=T transb=N
A_type=fp8 B_type=bf8 D_type=bf16 transa=T transb=N
A_type=fp8 B_type=fp8 D_type=bf16 bias_type=bf16 transa=T transb=N