Skip to content

cmake: don't set CMAKE_C_COMPILER, as hipBLAS is a CXX project - #877

Merged
TorreZuk merged 1 commit into
ROCm:release-staging/rocm-rel-6.2from
evetsso:no_cmake_c_compiler
Jun 7, 2024
Merged

cmake: don't set CMAKE_C_COMPILER, as hipBLAS is a CXX project#877
TorreZuk merged 1 commit into
ROCm:release-staging/rocm-rel-6.2from
evetsso:no_cmake_c_compiler

Conversation

@evetsso

@evetsso evetsso commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

See ROCm/rocPRIM#567 for a description of the errors solved by this change.

daineAMD
daineAMD approved these changes Jun 6, 2024
View reviewed changes

@daineAMD daineAMD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes, looks like cuda CI failed due to docker issues.
I can merge back into develop afterward.

TorreZuk
TorreZuk approved these changes Jun 6, 2024
View reviewed changes

@TorreZuk TorreZuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daineAMD

daineAMD commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

I think we'll need the change from 5f23b35 to go into release-staging/rocm-rel-6.2 as well to get static builds to pass, so I expect static CI to fail here.

I'm ok if you go ahead and merge this one even with the static failure and I can create a PR afterwards to include that change. Otherwise you can make that change here too if you want.

@daineAMD daineAMD mentioned this pull request Jun 6, 2024
Merged
@TorreZuk TorreZuk added the noSolver Run PR without rocSOLVER label Jun 7, 2024
@TorreZuk

TorreZuk commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Will re-run with noSOLVER to see if at least something can build.

@evetsso

evetsso commented Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

Will re-run with noSOLVER to see if at least something can build.

Thanks. FWIW, I've been able to manually build with my own rocSOLVER.

@TorreZuk

TorreZuk commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Re-run in CI passed on one OS without solver (non static) so IMO you are safe to merge.

@evetsso

evetsso commented Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

Oh.. seems I don't have permission to merge. @TorreZuk , @daineAMD I think one of you can probably do it?

@TorreZuk
TorreZuk merged commit aa9247c into ROCm:release-staging/rocm-rel-6.2 Jun 7, 2024
ammallya pushed a commit that referenced this pull request Oct 28, 2025
@evetsso
cmake: don't set CMAKE_C_COMPILER, as hipBLAS is a CXX project (#877)
950735b 
[ROCm/hipBLAS commit: aa9247c]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorreZuk TorreZuk TorreZuk approved these changes
@amcamd amcamd Awaiting requested review from amcamd
@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner
@bragadeesh bragadeesh Awaiting requested review from bragadeesh
@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner
@rkamd rkamd Awaiting requested review from rkamd
+1 more reviewer
@daineAMD daineAMD daineAMD approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci:static-libraries noSolver Run PR without rocSOLVER

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evetsso @daineAMD @TorreZuk