Skip to content

Develop branch for release after ROCm 7.0 #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daineAMD merged 1 commit into from
Jul 18, 2025
Merged

Develop branch for release after ROCm 7.0 #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ list( APPEND CMAKE_PREFIX_PATH ${ROCM_PATH}/lib/cmake/hip /opt/rocm /opt/rocm/ll
# rocm-cmake contains common cmake code for rocm projects to help setup and install
include(dependencies)

set ( VERSION_STRING "3.0.0" )
set ( VERSION_STRING "3.1.0" )
rocm_setup_version( VERSION ${VERSION_STRING} )

option( BUILD_VERBOSE "Output additional build information" OFF )
Expand Down Expand Up @@ -204,14 +204,14 @@ endif( )

# Package specific CPACK vars
if(HIP_PLATFORM STREQUAL amd)
set(rocblas_minimum 5.0.0)
set(rocsolver_minimum 3.30.0)
set(rocblas_minimum 5.1.0)
set(rocsolver_minimum 3.31.0)
rocm_package_add_dependencies(SHARED_DEPENDS "rocblas >= ${rocblas_minimum}" "rocsolver >= ${rocsolver_minimum}")
rocm_package_add_rpm_dependencies(STATIC_DEPENDS "rocblas-static-devel >= ${rocblas_minimum}" "rocsolver-static-devel >= ${rocsolver_minimum}")
rocm_package_add_deb_dependencies(STATIC_DEPENDS "rocblas-static-dev >= ${rocblas_minimum}" "rocsolver-static-dev >= ${rocsolver_minimum}")
endif( )

set(hipblas_common_minimum 1.1.0)
Copy link
Copy Markdown
Contributor

@TorreZuk TorreZuk May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well for dependencies not sure if we have a tight or loose policy for minimum version. Think solver must be loose as they always talk about using older rocblas too

set(hipblas_common_minimum 1.3.0)
if(BUILD_SHARED_LIBS)
rocm_package_add_deb_dependencies(COMPONENT devel DEPENDS "hipblas-common-dev >= ${hipblas_common_minimum}")
rocm_package_add_rpm_dependencies(COMPONENT devel DEPENDS "hipblas-common-devel >= ${hipblas_common_minimum}")
Expand Down
20 changes: 10 additions & 10 deletions bump_develop_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@

# For the develop branch, bump hipblas version and rocblas/rocsolver dependency versions

OLD_HIPBLAS_VERSION="2.5.0"
NEW_HIPBLAS_VERSION="3.0.0"
OLD_HIPBLAS_VERSION="3.0.0"
NEW_HIPBLAS_VERSION="3.1.0"

OLD_MINIMUM_ROCBLAS_VERSION="4.5.0"
NEW_MINIMUM_ROCBLAS_VERSION="5.0.0"
OLD_MINIMUM_ROCBLAS_VERSION="5.0.0"
NEW_MINIMUM_ROCBLAS_VERSION="5.1.0"

OLD_MINIMUM_ROCSOLVER_VERSION="3.29.0"
NEW_MINIMUM_ROCSOLVER_VERSION="3.30.0"
OLD_MINIMUM_ROCSOLVER_VERSION="3.30.0"
NEW_MINIMUM_ROCSOLVER_VERSION="3.31.0"

OLD_MINIMUM_HIPBLAS_COMMON_VERSION="1.0.0"
NEW_MINIMUM_HIPBLAS_COMMON_VERSION="1.1.0"
OLD_MINIMUM_HIPBLAS_COMMON_VERSION="1.1.0"
NEW_MINIMUM_HIPBLAS_COMMON_VERSION="1.3.0"

OLD_SO_VERSION="hipblas_SOVERSION 2.5"
NEW_SO_VERSION="hipblas_SOVERSION 3.0"
OLD_SO_VERSION="hipblas_SOVERSION 3.0"
NEW_SO_VERSION="hipblas_SOVERSION 3.1"

sed -i "s/${OLD_HIPBLAS_VERSION}/${NEW_HIPBLAS_VERSION}/g" CMakeLists.txt
sed -i "s/${OLD_MINIMUM_ROCBLAS_VERSION}/${NEW_MINIMUM_ROCBLAS_VERSION}/g" CMakeLists.txt
Expand Down
2 changes: 1 addition & 1 deletion library/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# ########################################################################

# This is incremented when the ABI to the library changes
set( hipblas_SOVERSION 3.0 )
set( hipblas_SOVERSION 3.1 )

list( APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake )

Expand Down