Adding missing __shfl overloads.#557
Closed
Jorghi12 wants to merge 2 commits into
Closed
Conversation
Added missing double overloads for __shfl operations.
Added definitions for __shfl double operations.
|
/cc @mangupta |
Contributor
|
@Jorghi12 please don't do it like so, we are in the process of moving most of HIP to being header only. please coordinate with @aaronenyeshi who is driving this to get the overloads you are missing into the right place. |
Contributor
|
FYI the PR that Alex mentioned is PR #515. |
Contributor
Contributor
|
Closing this since PR#515 now contains the changes that were required by this PR as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing double overloads for __shfl operations.