SWDEV-355608 - deprecate/cleanup hipcc link flags #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased the patch in #3093 and added minor updates |
gargrahul
force-pushed
the
rebase_pr3093
branch
from
8d5cc3d to
b548467
Compare
|
@scchan Please check the CI failures. |
|
@gargrahul I fixed the Unit_hipEventMgpuMThreads.cc test, which should be linking explicitly to the pthread library. |
gargrahul
force-pushed
the
rebase_pr3093
branch
from
571f6a4 to
b14fab4
Compare
gargrahul
force-pushed
the
rebase_pr3093
branch
from
0e38498 to
9f7c391
Compare
- deprecate -use-staticlib, -use-sharedlib which no longer provide any functional values - use --hip-link instead of specifying the HIP runtime by name when linking - fix linker option bug in HIT test's cmake - update build options for unit tests requiring pthread or rt Change-Id: Ib49978773c80fb40c71dc52b050ce921943ee3e4
gargrahul
force-pushed
the
rebase_pr3093
branch
from
9f7c391 to
739e83f
Compare
gargrahul
approved these changes
Jan 24, 2023
scchan
added a commit
to scchan/HIPCC
that referenced
this pull request
Feb 6, 2023
- deprecate -use-staticlib, -use-sharedlib which no longer provide any functional values - use --hip-link instead of specifying the HIP runtime by name when linking - fix linker option bug in HIT test's cmake - update build options for unit tests requiring pthread or rt This is essentially a C++ port of this patch in Perl: ROCm/hip#3128
scchan
added a commit
to ROCm/HIPCC
that referenced
this pull request
Feb 14, 2023
- deprecate -use-staticlib, -use-sharedlib which no longer provide any functional values - use --hip-link instead of specifying the HIP runtime by name when linking - fix linker option bug in HIT test's cmake - update build options for unit tests requiring pthread or rt This is essentially a C++ port of this patch in Perl: ROCm/hip#3128
rocm-ci
pushed a commit
that referenced
this pull request
May 1, 2023
- deprecate -use-staticlib, -use-sharedlib which no longer provide any functional values - use --hip-link instead of specifying the HIP runtime by name when linking - fix linker option bug in HIT test's cmake - update build options for unit tests requiring pthread or rt Change-Id: Ib49978773c80fb40c71dc52b050ce921943ee3e4
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Aug 23, 2023
- deprecate -use-staticlib, -use-sharedlib which no longer provide any functional values - use --hip-link instead of specifying the HIP runtime by name when linking - fix linker option bug in HIT test's cmake - update build options for unit tests requiring pthread or rt This is essentially a C++ port of this patch in Perl: ROCm/hip#3128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib49978773c80fb40c71dc52b050ce921943ee3e4