fix(hip): share Gather and tensor-shape contracts - #644
Draft
fhanuman wants to merge 1 commit into
Draft
Conversation
|
Thanks for opening a PR! This project follows LLVM's incremental-development and AI-tool-use Before requesting review, please check that:
Reviewers are assigned through |
L2 Accuracy Results (EP vs CPU)
Threshold: 0.01 | Run: 3893 - Commit: |
MorphiZen EP Performance Results
EPContext Export Performance
OGA Benchmark Results
OGA Wheel Smoke (Python benchmark_e2e.py)
Run: 3893 - Commit: |
fhanuman
force-pushed
the
pr/shape-stack-06-gather-tensor
branch
from
August 5, 2026 21:56
deb0a3f to
8db3876
Compare
fhanuman
force-pushed
the
pr/shape-stack-06-gather-tensor
branch
from
August 6, 2026 21:00
8db3876 to
9f06ab6
Compare
fhanuman
force-pushed
the
pr/shape-stack-06-gather-tensor
branch
from
August 7, 2026 19:51
9f06ab6 to
0858247
Compare
fhanuman
force-pushed
the
pr/shape-stack-06-gather-tensor
branch
2 times, most recently
from
August 10, 2026 21:59
a0455ce to
e337608
Compare
fhanuman
force-pushed
the
pr/shape-stack-06-gather-tensor
branch
from
August 10, 2026 22:29
e337608 to
af6a5a5
Compare
fhanuman
force-pushed
the
pr/shape-stack-06-gather-tensor
branch
from
August 10, 2026 23:33
af6a5a5 to
2cb9720
Compare
Unify Gather-family and tensor-shape contracts across conversion, reification, and verification while enforcing the runtime-supported i64 GatherND index ABI. Co-Authored-By: GPT-5.6 Sol <noreply@openai.com> Made-with: Cursor
fhanuman
force-pushed
the
pr/shape-stack-06-gather-tensor
branch
from
August 11, 2026 00:42
2cb9720 to
9dd4ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify result-shape construction, reification, and static verification for Gather-family and tensor-shape operations.
indicesoperand through the named same-shape contract;GatherND retains its DPS-init fallback when the runtime tuple width prevents static output-rank inference.
Stack
This is PR 9 of 12 and depends on PR 8:
AI assistance
AI tools assisted with the shape-contract refactoring and stack reconstruction. The changes were checked with the local build, focused Gather/Transpose/Resize/Size LIT, and targeted GPU-vs-CPU tests.
Made with Cursor