fix(hip): share MatMul and Gemm shapes with dynamic batch validation - #640
Draft
fhanuman wants to merge 1 commit into
Draft
fix(hip): share MatMul and Gemm shapes with dynamic batch validation#640fhanuman wants to merge 1 commit into
fhanuman wants to merge 1 commit into
Conversation
|
Thanks for opening a PR! This project follows LLVM's incremental-development and AI-tool-use Before requesting review, please check that:
Reviewers are assigned through |
L2 Accuracy Results (EP vs CPU)
Threshold: 0.01 | Run: 3890 - Commit: |
MorphiZen EP Performance Results
EPContext Export Performance
EPContext Import Performance
OGA Benchmark Results
OGA Wheel Smoke (Python benchmark_e2e.py)
Run: 3890 - Commit: |
fhanuman
force-pushed
the
pr/shape-stack-02-matmul-gemm
branch
from
August 5, 2026 21:56
9312980 to
f4f5cc3
Compare
fhanuman
force-pushed
the
pr/shape-stack-02-matmul-gemm
branch
2 times, most recently
from
August 7, 2026 19:51
a7dd44e to
6cbba55
Compare
fhanuman
force-pushed
the
pr/shape-stack-02-matmul-gemm
branch
from
August 7, 2026 20:25
6cbba55 to
c217451
Compare
fhanuman
changed the base branch from
pr/shape-stack-01-foundation
to
pr/shape-stack-01b-reshape-provenance
August 7, 2026 22:12
fhanuman
force-pushed
the
pr/shape-stack-02-matmul-gemm
branch
2 times, most recently
from
August 10, 2026 22:29
ea4515c to
f519c86
Compare
fhanuman
force-pushed
the
pr/shape-stack-02-matmul-gemm
branch
from
August 10, 2026 23:33
f519c86 to
52f86a3
Compare
Unify converter, reification, verification, lowering, and runtime behavior while validating dynamic contraction extents and every broadcast batch axis before checked dispatch. Co-Authored-By: GPT-5.6 Sol <noreply@openai.com> Made-with: Cursor
fhanuman
force-pushed
the
pr/shape-stack-02-matmul-gemm
branch
from
August 11, 2026 00:42
52f86a3 to
9d7fdec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify MatMul, Gemm, and MatMulNBits result-shape construction across ONNX conversion, HIP reification, and static verification.
Compiled model artifacts using the previous MatMul wrapper ABI must be invalidated.
Stack
This is PR 4 of 12 and depends on PR 3:
AI assistance
AI tools assisted with the refactoring and stack reconstruction. The complete compiler/runtime ABI slice was checked with the authoritative local build and focused MatMul/Gemm tests.
Made with Cursor