Skip to content

fix(matmul-lowering): use extractMemRefDataPtr for offset-correct pointers #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kirankumarmatam-amd wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(matmul-lowering): use extractMemRefDataPtr for offset-correct pointers #626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
918c161
fix(matmul-lowering): use extractMemRefDataPtr for offset-correct poi…
kirankumarmatam-amd Aug 1, 2026
f56d69d
fix(matmul-lowering): tighten comment, remove internal bug ref
kirankumarmatam-amd Aug 2, 2026
92eed51
fix(matmul-lowering): clang-format extractMemRefDataPtr call alignment
kirankumarmatam-amd Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions lib/Conversion/HipToLLVM/MatmulLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,22 @@ struct MatmulOpLowering : public ConvertOpToLLVMPattern<MatmulOp> {
rewriter.getI64IntegerAttr(value));
};

// Extract pointers
// Use extractMemRefDataPtr (alignedPtr + GEP(offset)) so that subview
// operands with non-zero descriptor offsets are correctly adjusted.
// extractContiguousMemRefPtr returns alignedPtr only and silently reads
// the parent buffer base when offset != 0.
Value statePtr = adaptor.getCtx();
Value APtr = extractContiguousMemRefPtr(adaptor.getA(), rewriter, loc);
Value BPtr = extractContiguousMemRefPtr(adaptor.getB(), rewriter, loc);
Value outputPtr =
extractContiguousMemRefPtr(adaptor.getOutput(), rewriter, loc);

// Get memref types and shapes
auto AType = cast<MemRefType>(op.getA().getType());
auto BType = cast<MemRefType>(op.getB().getType());
auto OutType = cast<MemRefType>(op.getOutput().getType());
Value APtr = extractMemRefDataPtr(adaptor.getA(), AType, getTypeConverter(),
rewriter, loc);
Value BPtr = extractMemRefDataPtr(adaptor.getB(), BType, getTypeConverter(),
rewriter, loc);
Value outputPtr = extractMemRefDataPtr(adaptor.getOutput(), OutType,
getTypeConverter(), rewriter, loc);

// Get memref types and shapes
int64_t ARank = AType.getRank();
int64_t BRank = BType.getRank();

Expand Down
Loading