Skip failing C++ tests and fix mma_debug_utils#59
Merged
demandal25 merged 1 commit intoROCm:amd-integrationfrom Nov 18, 2025
Merged
Skip failing C++ tests and fix mma_debug_utils#59demandal25 merged 1 commit intoROCm:amd-integrationfrom
demandal25 merged 1 commit intoROCm:amd-integrationfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a mechanism to skip failing C++ tests from the CMake build_tests target while allowing them to be built individually, and fixes a missing header include in mma_debug_utils_hip.h.
- Added a
SKIPPED_TESTSlist in CMake to exclude specific failing tests from thebuild_teststarget and test discovery - Fixed missing
fastdiv.cuhinclude inmma_debug_utils_hip.hthat provides theuint_fastdivtype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libflashinfer/tests/CMakeLists.txt | Implements test skipping mechanism by filtering out specified tests from gtest_discover_tests() and build_tests dependencies |
| libflashinfer/include/gpu_iface/backend/hip/mma_debug_utils_hip.h | Adds missing include for fastdiv.cuh to provide uint_fastdiv type used in debug_print_o_from_gmem() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Nov 18, 2025
diptorupd
pushed a commit
that referenced
this pull request
Dec 5, 2025
This PR adds `kLinear` swizzle option to `permuted_smem`. It also modifies `get_permuted_offset`, `advance_offset_by_row` and `advance_offset_by_column` accordingly
diptorupd
added a commit
that referenced
this pull request
Dec 5, 2025
The PR adds a list to tests to skip from the CMake `build_tests` target. The tests in the skip list can still be individually built. E.g. ```bash # The `test_batch_prefill.cpp` is currently broken and added to the skip list. cmake -DFLASHINFER_ENABLE_HIP=ON -DFLASHINFER_UNITTESTS=ON -GNinja .. ninja build_tests # does not build the test_batch_prefill.cpp tests # The test file can still be built individually using ninja test_batch_prefill_hip ``` Also added the fix to `mma_debug_utils_hip.hpp` from #52 Supersedes #52, #57
zhenhantech
pushed a commit
to zhenhantech/flashinfer
that referenced
this pull request
Jan 9, 2026
This PR adds `kLinear` swizzle option to `permuted_smem`. It also modifies `get_permuted_offset`, `advance_offset_by_row` and `advance_offset_by_column` accordingly
zhenhantech
pushed a commit
to zhenhantech/flashinfer
that referenced
this pull request
Jan 9, 2026
The PR adds a list to tests to skip from the CMake `build_tests` target. The tests in the skip list can still be individually built. E.g. ```bash # The `test_batch_prefill.cpp` is currently broken and added to the skip list. cmake -DFLASHINFER_ENABLE_HIP=ON -DFLASHINFER_UNITTESTS=ON -GNinja .. ninja build_tests # does not build the test_batch_prefill.cpp tests # The test file can still be built individually using ninja test_batch_prefill_hip ``` Also added the fix to `mma_debug_utils_hip.hpp` from ROCm#52 Supersedes ROCm#52, ROCm#57
diptorupd
pushed a commit
to diptorupd/flashinfer
that referenced
this pull request
Jan 28, 2026
This PR adds `kLinear` swizzle option to `permuted_smem`. It also modifies `get_permuted_offset`, `advance_offset_by_row` and `advance_offset_by_column` accordingly
diptorupd
added a commit
to diptorupd/flashinfer
that referenced
this pull request
Jan 28, 2026
The PR adds a list to tests to skip from the CMake `build_tests` target. The tests in the skip list can still be individually built. E.g. ```bash # The `test_batch_prefill.cpp` is currently broken and added to the skip list. cmake -DFLASHINFER_ENABLE_HIP=ON -DFLASHINFER_UNITTESTS=ON -GNinja .. ninja build_tests # does not build the test_batch_prefill.cpp tests # The test file can still be built individually using ninja test_batch_prefill_hip ``` Also added the fix to `mma_debug_utils_hip.hpp` from ROCm#52 Supersedes ROCm#52, ROCm#57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a list to tests to skip from the CMake
build_teststarget. The tests in the skip list can still be individually built.E.g.
Also added the fix to
mma_debug_utils_hip.hppfrom #52Supersedes #52, #57