Skip to content

Add DeviceBatchedGemmMultipleD_Dl#732

Merged
zjing14 merged 6 commits into
developfrom
barkocot/batched-gemm-dl
Jun 12, 2023
Merged

Add DeviceBatchedGemmMultipleD_Dl#732
zjing14 merged 6 commits into
developfrom
barkocot/batched-gemm-dl

Conversation

@bartekxk
Copy link
Copy Markdown
Contributor

@bartekxk bartekxk commented May 31, 2023

No description provided.

@bartekxk bartekxk force-pushed the barkocot/batched-gemm-dl branch from e3b2e0e to aebc74d Compare June 1, 2023 08:59
@bartekxk bartekxk requested a review from aosewski June 1, 2023 09:01
@bartekxk bartekxk force-pushed the barkocot/batched-gemm-dl branch from aebc74d to 572be20 Compare June 1, 2023 09:06
aosewski
aosewski reviewed Jun 1, 2023
View reviewed changes
Comment thread library/include/ck/library/tensor_operation_instance/gpu/batched_gemm_multi_d.hpp Outdated
aosewski
aosewski requested changes Jun 1, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aosewski aosewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks. In general please try to use googltest for tests.

Comment thread profiler/include/profiler/profile_batched_gemm_impl.hpp Outdated
Comment thread test/batched_gemm_multi_d/batched_gemm_multi_d_fp16.cpp Outdated
Comment thread test/batched_gemm_multi_d/batched_gemm_multi_d_int8.cpp Outdated
Comment thread include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multiple_d_dl.hpp Outdated
Comment thread include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multiple_d_dl.hpp Outdated
@bartekxk bartekxk self-assigned this Jun 1, 2023
@bartekxk bartekxk requested a review from aosewski June 5, 2023 11:49
@bartekxk bartekxk force-pushed the barkocot/batched-gemm-dl branch from 27b3092 to d2c6d96 Compare June 5, 2023 12:14
@bartekxk bartekxk requested a review from zjing14 June 5, 2023 21:24
aosewski
aosewski requested changes Jun 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aosewski aosewski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Aren't such tests beautiful, concise and much more easily maintainable? :) Apart from that - please get rid of this assert statement.

Comment thread include/ck/tensor_operation/gpu/device/impl/device_batched_gemm_multiple_d_dl.hpp Outdated
Comment thread test/batched_gemm_multi_d/test_batched_gemm_multi_d.cpp Outdated
Comment thread test/batched_gemm_multi_d/test_batched_gemm_multi_d.cpp Outdated
Comment thread test/batched_gemm_multi_d/test_batched_gemm_multi_d.cpp Outdated
@bartekxk bartekxk requested a review from aosewski June 6, 2023 12:20
aosewski
aosewski previously approved these changes Jun 6, 2023
View reviewed changes
@bartekxk bartekxk force-pushed the barkocot/batched-gemm-dl branch from 896e1bb to dba99f8 Compare June 6, 2023 21:19
@bartekxk bartekxk force-pushed the barkocot/batched-gemm-dl branch from dba99f8 to 0f48e38 Compare June 9, 2023 13:01
@aosewski aosewski self-requested a review June 12, 2023 08:34
@zjing14 zjing14 merged commit fc9f975 into develop Jun 12, 2023
@illsilin illsilin mentioned this pull request Jun 16, 2023
Merged
@illsilin illsilin deleted the barkocot/batched-gemm-dl branch December 7, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aosewski aosewski aosewski approved these changes

@zjing14 zjing14 Awaiting requested review from zjing14

Assignees

@bartekxk bartekxk

Labels

CI - Pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartekxk @aosewski @zjing14