Skip to content

[Navi3x Bug Fix] fix typo to accept MNKPadding flag correctly. #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asroy merged 6 commits into from
Mar 1, 2023
Merged

[Navi3x Bug Fix] fix typo to accept MNKPadding flag correctly. #597

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e5fb9fa
fix a bug blocking wmma_gemm_multipleD
aska-0096 Feb 22, 2023
6501887
Utilize matrix padder in device_wmma_op
aska-0096 Feb 24, 2023
5688802
cosmetic change for gemmpadding format
aska-0096 Mar 1, 2023
253045d
Merge branch 'develop' of https://github.com/ROCmSoftwarePlatform/com…
aska-0096 Mar 1, 2023
ef16ed4
clang format
aska-0096 Mar 1, 2023
ba029a1
Change gridwise gemm from FIFO to KMN loop fashion
aska-0096 Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/ck/tensor_operation/gpu/device/impl/device_gemm_multiple_d_wmma_cshuffle.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ struct DeviceGemmMultipleD_Wmma_CShuffle : public DeviceGemmMultipleD<ALayout,
#endif
}();

if constexpr(GemmSpec == GemmSpecialization::MNPadding)
if constexpr(GemmSpec == GemmSpecialization::MNKPadding)
Comment thread
asroy marked this conversation as resolved.
Outdated
{
const auto PadM = (MPerBlock - M % MPerBlock) % MPerBlock;

Expand Down Expand Up @@ -144,7 +144,7 @@ struct DeviceGemmMultipleD_Wmma_CShuffle : public DeviceGemmMultipleD<ALayout,
}
}();

if constexpr(GemmSpec == GemmSpecialization::MNPadding)
if constexpr(GemmSpec == GemmSpecialization::MNKPadding)
{
const auto PadN = (NPerBlock - N % NPerBlock) % NPerBlock;

Expand Down Expand Up @@ -180,7 +180,7 @@ struct DeviceGemmMultipleD_Wmma_CShuffle : public DeviceGemmMultipleD<ALayout,
}
}();

if constexpr(GemmSpec == GemmSpecialization::MNPadding)
if constexpr(GemmSpec == GemmSpecialization::MNKPadding)
{
const auto PadM = (MPerBlock - M % MPerBlock) % MPerBlock;
const auto PadN = (NPerBlock - N % NPerBlock) % NPerBlock;
Expand Down