[Bug fix] GridwiseGemm_k0mk1_k0nk1_mn_xdlops_v2r3 k0 main loop#45
Merged
Conversation
carlushuang
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Use kernel shape to define encoding * Remove redundant blockSize * Save mean and invStd * Refine SAVE_MEAN_INV_STD * Refine template parameter name * Let mean var tensor easier to get * Add InvSqrt() function, prepare to add fast InvSqrt algorithm * Refine function name * remove useless reference * Rename kXNumWarps to kXWarpPerBlock * Refine InvSqrt() * remove if condition, global write is warp level, if condition is useless here
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GridwiseGemm_k0mk1_k0nk1_mn_xdlops_v2r3, sometimes there is no main K0 loop. So you need to detect that on host, and not using main K0 loop in the kernel.
GridwiseGemm_bk0mk1_bk0nk1_mn_xdlops_v2r4 has same issue, and need to be fixed in separate PR