Skip to content

[CK_TILE] Non-K Major from old CK to CK-Tile - fix reverted PR#3199

Merged
samremes merged 7 commits into
developfrom
samremes/redo_lds_nonkmajor
Nov 18, 2025
Merged

[CK_TILE] Non-K Major from old CK to CK-Tile - fix reverted PR#3199
samremes merged 7 commits into
developfrom
samremes/redo_lds_nonkmajor

Conversation

@samremes
Copy link
Copy Markdown
Contributor

@samremes samremes commented Nov 12, 2025

Proposed changes

Unrevert previous revert #3017 of #2442

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@aosewski aosewski marked this pull request as ready for review November 17, 2025 11:56
@samremes samremes merged commit 3ede8e2 into develop Nov 18, 2025
21 checks passed
@samremes samremes deleted the samremes/redo_lds_nonkmajor branch November 18, 2025 08:17
AviralGoelAMD pushed a commit that referenced this pull request Nov 28, 2025
@samremes @aosewski @AviralGoelAMD
[CK_TILE] Non-K Major from old CK to CK-Tile - fix reverted PR (#3199)
6473beb 
* Reapply "[CK_TILE] Non-K Major from old CK to CK-Tile (#2442)" (#3017)

This reverts commit e4298e5.

* WIP

* take Y2 as the AK1/BK1 value, that is the 'vector size' after shuffle

* use get_n_lds_banks()

* clang-format

---------

Co-authored-by: Adam Osewski <19374865+aosewski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aosewski aosewski aosewski approved these changes

@illsilin illsilin Awaiting requested review from illsilin illsilin is a code owner

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@qianfengz qianfengz Awaiting requested review from qianfengz qianfengz is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

@afagaj afagaj Awaiting requested review from afagaj afagaj is a code owner

@asleepzzz asleepzzz Awaiting requested review from asleepzzz asleepzzz is a code owner

@tenpercent tenpercent Awaiting requested review from tenpercent tenpercent is a code owner

@ThomasNing ThomasNing Awaiting requested review from ThomasNing ThomasNing is a code owner

@coderfeli coderfeli Awaiting requested review from coderfeli coderfeli is a code owner

@cgmillette cgmillette Awaiting requested review from cgmillette cgmillette is a code owner

@shumway shumway Awaiting requested review from shumway shumway is a code owner

@vidyasagar-amd vidyasagar-amd Awaiting requested review from vidyasagar-amd vidyasagar-amd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samremes @aosewski