Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
d4bc3a9
Initial commit. create batched_contraction_kernel file
msaffari-amd Sep 4, 2025
15ec347
initial problem definition
msaffari-amd Sep 5, 2025
7e731d4
implement initial example to launch kernel
msaffari-amd Sep 5, 2025
a440c72
add universal gemm to contraction. initial phase
msaffari-amd Sep 8, 2025
c9bf6f6
complete implementation for special case all Dims are 1 and no Ds
msaffari-amd Sep 9, 2025
dbaacf1
clean code
msaffari-amd Sep 9, 2025
1bdc69f
initial changes to support multi dimensional G
msaffari-amd Sep 9, 2025
751f229
more progress in implementing multiple G
msaffari-amd Sep 10, 2025
bc2fabe
tmp commit
msaffari-amd Sep 11, 2025
bd70caf
manage dynamic NumDimG in kernel
msaffari-amd Sep 11, 2025
baf2dd5
improving example for multi M,N,K,G handling. start generalizing kern…
msaffari-amd Sep 14, 2025
dc35e4f
implement the example for general Multi dimension G M N K and test di…
msaffari-amd Sep 15, 2025
94f63bc
2 functions for reference using multi dimensional and flat indexing
msaffari-amd Sep 15, 2025
4782643
clean the code for muti dimentional G, M, N, K contraction and add so…
msaffari-amd Sep 16, 2025
ad71007
Add Make descriptor function in kernel for merging Ms, Ns, Ks for A, …
msaffari-amd Sep 16, 2025
1e65d79
some cleaning on kernel
msaffari-amd Sep 17, 2025
9a1b0a3
clean the code for calculating the offsets from flatten batch number
msaffari-amd Sep 17, 2025
fdea5b8
Start adding MultiD support to kernel and example
msaffari-amd Sep 17, 2025
eaf377d
more changes to manage multi D in kernel and example
msaffari-amd Sep 18, 2025
638d554
manage passing multi d to kernel and testing.
msaffari-amd Sep 19, 2025
a7e7156
complete multi D support in kernel. modify example code to support it
msaffari-amd Sep 22, 2025
8384658
Correct algorithm to calc the correct offset values for D tensor batc…
msaffari-amd Sep 22, 2025
131f166
Minor fix
msaffari-amd Sep 23, 2025
5d83464
Merge branch 'develop' into LWPCK-3688-cktile-contraction-multi-D
msaffari-amd Sep 23, 2025
4f89943
Generalize example code for variable NumD tensors and apply cleanup b…
msaffari-amd Sep 24, 2025
a0e48cb
Merge branch 'develop' into LWPCK-3688-cktile-contraction-multi-D
aosewski Sep 26, 2025
a3e0b29
Refactored code and addressed review feedback
msaffari-amd Sep 29, 2025
a09b54b
refactoring, cleaning, add documents, in kernel side and example codes
msaffari-amd Oct 1, 2025
120c650
merge develop
msaffari-amd Oct 1, 2025
e2203ba
Merge branch 'develop' into LWPCK-3688-cktile-contraction-multi-D
aosewski Oct 3, 2025
617048c
Optimize batch offset calculation in kernel
msaffari-amd Oct 6, 2025
01dfca2
Merge branch 'develop' into LWPCK-3688-cktile-contraction-multi-D
msaffari-amd Oct 7, 2025
2df6ce8
Merge branch 'develop' into LWPCK-3688-cktile-contraction-multi-D
aosewski Oct 9, 2025
b430501
Inline CalculateBatchOffset in batched contraction kernel, update CHA…
msaffari-amd Oct 9, 2025
143844f
Merge branch 'develop' into LWPCK-3688-cktile-contraction-multi-D
msaffari-amd Oct 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Documentation for Composable Kernel available at [https://rocm.docs.amd.com/proj
* Added the row-wise column-wise quantization for CK_TILE GEMM & CK_TILE Grouped GEMM.
* Added support for f32 to FMHA (fwd/bwd).
* Added tensor-wise quantization for CK_TILE GEMM.
* Added support for batched contraction kernel.
* Added pooling kernel in CK_TILE

### Optimized
Expand Down
7 changes: 7 additions & 0 deletions example/ck_tile/41_batched_contraction/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
add_executable(tile_example_batched_contraction EXCLUDE_FROM_ALL batched_contraction.cpp)
set(EXAMPLE_CONTRACTION_COMPILE_OPTIONS)
if(CK_USE_OCP_FP8)
list(APPEND EXAMPLE_CONTRACTION_COMPILE_OPTIONS -DCK_TILE_USE_OCP_FP8)
endif()

target_compile_options(tile_example_batched_contraction PRIVATE ${EXAMPLE_CONTRACTION_COMPILE_OPTIONS})
245 changes: 245 additions & 0 deletions example/ck_tile/41_batched_contraction/batched_contraction.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,245 @@
// SPDX-License-Identifier: MIT
// Copyright (c) 2025, Advanced Micro Devices, Inc. All rights reserved.

#include <hip/hip_runtime.h>

#include <cstring>
#include <iostream>
#include <sstream>
#include <string>
#include <tuple>

#include "ck_tile/core.hpp"
#include "ck_tile/ops/epilogue.hpp"
#include "ck_tile/ops/gemm.hpp"
#include "ck_tile/host.hpp"

#include "ck_tile/ops/batched_contraction.hpp"
#include "contraction_utils.hpp"

template <typename ADataType,
typename BDataType,
typename DsDataType,
typename AccDataType,
typename EDataType,
typename ALayout,
typename BLayout,
typename DsLayout,
typename ELayout,
ck_tile::index_t NumDimG,
ck_tile::index_t NumDimM,
ck_tile::index_t NumDimN,
ck_tile::index_t NumDimK,
typename CDEElementWise = ck_tile::element_wise::PassThrough>

float batched_contraction_impl(const ck_tile::BatchedContractionHostArgs<DsDataType::size()>& args,
const ck_tile::stream_config& s)
{
constexpr ck_tile::index_t M_Tile = 256;
constexpr ck_tile::index_t N_Tile = 256;
constexpr ck_tile::index_t K_Tile = 64;

constexpr ck_tile::index_t M_Warp = 2;
constexpr ck_tile::index_t N_Warp = 2;
constexpr ck_tile::index_t K_Warp = 1;

constexpr ck_tile::index_t M_Warp_Tile = 32;
constexpr ck_tile::index_t N_Warp_Tile = 32;
constexpr ck_tile::index_t K_Warp_Tile = 16;

constexpr bool DoubleSmemBuffer = false;

constexpr bool kPadM = false;
constexpr bool kPadN = false;
constexpr bool kPadK = false;

constexpr bool TransposeC = false;

constexpr int kBlockPerCu = 1;
constexpr ck_tile::index_t TileParitionerGroupNum = 8;
constexpr ck_tile::index_t TileParitionerM01 = 4;

using GemmShape =
ck_tile::TileGemmShape<ck_tile::sequence<M_Tile, N_Tile, K_Tile>,
ck_tile::sequence<M_Warp, N_Warp, K_Warp>,
ck_tile::sequence<M_Warp_Tile, N_Warp_Tile, K_Warp_Tile>>;
using TilePartitioner = ck_tile::
GemmSpatiallyLocalTilePartitioner<GemmShape, TileParitionerGroupNum, TileParitionerM01>;

using Traits = ck_tile::TileGemmTraits<kPadM, kPadN, kPadK, ALayout, BLayout, ELayout>;
using GemmUniversalTraits = ck_tile::TileGemmUniversalTraits<kPadM,
kPadN,
kPadK,
DoubleSmemBuffer,
ALayout,
BLayout,
ELayout,
TransposeC>;

using Problem = ck_tile::BatchedContractionProblem<ADataType,
BDataType,
DsDataType,
EDataType,
NumDimG, // NumDimG
NumDimM, // NumDimM
NumDimN, // NumDimN
NumDimK, // NumDimK
DsDataType::size() // NumDTensor
>;

using GemmPipelineProblem =
ck_tile::GemmPipelineProblem<ADataType, BDataType, AccDataType, GemmShape, Traits>;

using BaseGemmPipeline = UNIVERSAL_GEMM_PIPELINE<GemmPipelineProblem>;

ck_tile::index_t K_total = 1;
for(ck_tile::index_t i = NumDimG + NumDimM; i < NumDimG + NumDimM + NumDimK; ++i)
{
K_total *= args.A_dims[i];
}

const ck_tile::index_t num_loop = TilePartitioner::GetLoopNum(K_total);
const bool has_hot_loop = BaseGemmPipeline::BlockHasHotloop(num_loop);
const ck_tile::TailNumber tail_num = BaseGemmPipeline::GetBlockLoopTailNum(num_loop);

float ave_time{0};

const auto Run = [&](const auto has_hot_loop_, const auto tail_number_) {
constexpr bool has_hot_loop_v = has_hot_loop_.value;
constexpr auto tail_number_v = tail_number_.value;
constexpr auto scheduler = GEMM_PIPELINE_SCHEDULER;
constexpr auto memory_operation =
ck_tile::memory_operation_enum::set; // Always set (no atomic_add)

using UniversalGemmProblem = ck_tile::UniversalGemmPipelineProblem<ADataType,
BDataType,
AccDataType,
GemmShape,
GemmUniversalTraits,
scheduler,
has_hot_loop_v,
tail_number_v>;

using GemmPipeline = GEMM_PIPELINE<UniversalGemmProblem>;

using GemmEpilogue = ck_tile::CShuffleEpilogue<
ck_tile::CShuffleEpilogueProblem<ADataType,
BDataType,
DsDataType,
AccDataType,
EDataType,
DsLayout,
ELayout,
CDEElementWise,
TilePartitioner::MPerBlock,
TilePartitioner::NPerBlock,
M_Warp,
N_Warp,
M_Warp_Tile,
N_Warp_Tile,
K_Warp_Tile,
UniversalGemmProblem::TransposeC,
memory_operation>>;

using Kernel =
ck_tile::BatchedContractionKernel<Problem, TilePartitioner, GemmPipeline, GemmEpilogue>;
auto kargs = Kernel::MakeKernelArgs(args);

const dim3 grids = Kernel::GridSize(kargs);
const dim3 blocks = Kernel::GetBlockSize();

if(!Kernel::IsSupportedArguments(kargs))
{
throw std::runtime_error("Wrong! Arguments not supported! Skipping contraction!\n");
}

if(s.log_level_ > 0)
{
std::cout << "Launching kernel with args: " << Kernel::GetKernelName() << '\n'
<< "shape: " << GemmShape::GetName() << '\n'
<< "problem: " << GemmPipelineProblem::GetName() << '\n'
<< "pipeline: " << GemmPipeline::GetName() << '\n'
<< "grid: {" << grids.x << ", " << grids.y << ", " << grids.z << "}"
<< ", blocks: {" << blocks.x << ", " << blocks.y << ", " << blocks.z << "}"
<< std::endl;
}

auto kernel = ck_tile::make_kernel<kBlockPerCu>(Kernel{}, grids, blocks, 0, kargs);

ave_time = ck_tile::launch_kernel(s, kernel);

return ave_time;
};

BaseGemmPipeline::TailHandler(Run, has_hot_loop, tail_num);

return ave_time;
}

#define HANDLE_CASE(G, M, N, K) \
Comment thread
msaffari-amd marked this conversation as resolved.
if(num_g_dims == G && num_m_dims == M && num_n_dims == N && num_k_dims == K) \
{ \
return batched_contraction_impl<ADataType, \
BDataType, \
DsDataType, \
AccDataType, \
EDataType, \
ALayout, \
BLayout, \
DsLayout, \
ELayout, \
G, \
M, \
N, \
K, \
CDEElementWise>(args, s); \
}

template <typename ADataType,
typename BDataType,
typename DsDataType,
typename AccDataType,
typename EDataType,
typename ALayout,
typename BLayout,
typename DsLayout,
typename ELayout,
typename CDEElementWise = ck_tile::element_wise::PassThrough>
float batched_contraction(const ck_tile::BatchedContractionHostArgs<DsDataType::size()>& args,
const ck_tile::stream_config& s,
ck_tile::index_t num_g_dims,
ck_tile::index_t num_m_dims,
ck_tile::index_t num_n_dims,
ck_tile::index_t num_k_dims)
{
std::cout << "Dimensions: G=" << num_g_dims << ", M=" << num_m_dims << ", N=" << num_n_dims
<< ", K=" << num_k_dims << std::endl;

HANDLE_CASE(1, 1, 1, 1);
HANDLE_CASE(2, 1, 1, 1);
HANDLE_CASE(2, 2, 2, 1);
HANDLE_CASE(1, 2, 1, 1);
HANDLE_CASE(1, 1, 1, 2);
HANDLE_CASE(2, 2, 2, 2);
HANDLE_CASE(4, 4, 4, 4);

throw std::runtime_error(
"Unsupported dimension combination: G=" + std::to_string(num_g_dims) +
", M=" + std::to_string(num_m_dims) + ", N=" + std::to_string(num_n_dims) +
", K=" + std::to_string(num_k_dims) + ". Please add this combination to the kernel.");
}

#include "run_batched_contraction_example.inc"

int main(int argc, char* argv[])
{
try
{
return !run_batched_contraction_example(argc, argv);
}
catch(const std::runtime_error& e)
{
std::cerr << "Runtime error: " << e.what() << '\n';
return EXIT_FAILURE;
}
}
Loading
Loading