Update to gemm_reduce and batched_gemm_reduce#213
Merged
Conversation
asroy
approved these changes
Apr 29, 2022
| false>; | ||
|
|
||
| using ThreadwiseReduce_D1 = | ||
| ThreadwiseReduction<FloatReduceAcc, |
Contributor
There was a problem hiding this comment.
[Future improvement] ThreadwiseReduction could have a template param that specify pointwise operation, so that we don't need separate static_for loop for pointwise operation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This P.R picked two commit from PR.211 5c60 and PR.211 8857 and provides the following
Threadwise-reducefunction to do thread local reduction in thegemm_reduce_xdl_cshuffle kernelReduceSumand ReduceSquareSumdefined in element_wise_reduction_operation.hpp by using Add operation defined in reduction_operator.hpp (ReduceSquareSumis replaced byAddoperation andSquare` Elementwise operation)ReduceOperationobject inMakeArgumentPointer()(no need sinceReduceOperationtype is enough)