Skip to content

Reject VMM allocations in hipIpcGetMemHandle #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zyzshishui wants to merge 1 commit into from
Closed

Reject VMM allocations in hipIpcGetMemHandle #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rocclr/device/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,6 +1051,13 @@ bool Device::IpcCreate(void* dev_ptr, size_t* mem_size, char* handle, size_t* me
return false;
}

// VMM allocations must use hipMemExportToShareableHandle for IPC.
if (amd_mem_obj->getMemFlags() & CL_MEM_VA_RANGE_AMD) {
ClPrint(amd::LOG_DETAIL_DEBUG, amd::LOG_MEM,
"IPC is not supported for VMM allocations (dev_ptr: 0x%x)", dev_ptr);
return false;
}

// Get the original pointer from the amd::Memory object
void* orig_dev_ptr = nullptr;
if (amd_mem_obj->getSvmPtr() != nullptr) {
Expand Down
Loading