You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Windows: Use is_versioned = true consistently in both Comgr::LoadLib paths. - #243
Prior to this, RTCProgram was using is_version = true and device initialization was using false. On Windows, this was causing us to attempt to load amd_comgr_3.dll at device load and amd_comgr0605.dll for RTC programs. Obviously, there is only one DLL and it must be used consistently.
I don't think this is correct. On Windows, hipRTC uses the versioned comgr provided by the HIP SDK (bundled with the app) for bitcode linking.
But the HIP runtime will still use the non-versioned one provided by driver installation.
hipsdk is actually not the primary windows build system anymore. We should figure out how to support it, but the primary build system that is being used for shipping ROCm on windows is https://github.com/ROCm/TheRock -- and that lays the files out like Linux does, without the driver/app split. We should figure out how to support hipsdk, but we cannot block OSS patches to a proprietary part of the stack that can only be built at AMD.
(we've been going through and stripping out all cases where the assumption was made that WINDOWS = hipsdk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, RTCProgram was using is_version = true and device initialization was using false. On Windows, this was causing us to attempt to load amd_comgr_3.dll at device load and amd_comgr0605.dll for RTC programs. Obviously, there is only one DLL and it must be used consistently.
See #162