[OpenMP][omptest] Adopt omptest installation guard into scripts#1549
Merged
mhalk merged 1 commit intoROCm:aomp-devfrom Aug 27, 2025
Merged
Conversation
Enable installation of omptest for 'project' and 'openmp' components by default. See: llvm/llvm-project#155433
jplehr
approved these changes
Aug 26, 2025
Contributor
jplehr
left a comment
There was a problem hiding this comment.
lgtm
Do we need to land llvm-project change first or is this option simply ignored w/o the llvm patch?
Contributor
Author
No, the option is "ignored". CMake Warning:
Manually-specified variables were not used by the project:
DEVICELIBS_ROOT
LIBOMPTARGET_AMDGCN_GFXLIST
LIBOMPTARGET_ENABLE_DEBUG
LIBOMPTARGET_LLVM_INCLUDE_DIRS
LIBOMPTARGET_NVPTX_BC_LINKER
LIBOMPTARGET_NVPTX_COMPUTE_CAPABILITIES
LIBOMPTARGET_NVPTX_CUDA_COMPILER
LIBOMPTARGET_NVPTX_ENABLE_BCLIB
LIBOMPTEST_INSTALL_COMPONENTS # Patch adds this line while upstream PR still unmerged
LLVM_DIR
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR
LLVM_LIBDIR_SUFFIX
LLVM_MAIN_INCLUDE_DIR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable installation of omptest for 'project' and 'openmp' components by default.
See: llvm/llvm-project#155433
Motivation
Installation of omptests is going to be guarded but a subset of tests depends on it.
Hence, we want to install the corresponding components of omptest.
Technical Details
Added
-DLIBOMPTEST_INSTALL_COMPONENTS=ONto the common CMake options.Test Plan
Verified presence of installation manually with and without the patch.
Test Result
Without the patch no files matching
*omptest*are present in the AOMP installation directory.With the patch each configuration has a corresponding omptest installation.