Repository navigation
[Triton/Gluon] [Perf] unified_attention: split KV by actual sequence lengths under CUDA graphs (gfx950, head 64, bf16 Q / fp8 KV) #7088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuychang
wants to merge
30
commits into
ROCm:main
Choose a base branch
from
yuychang:k3/unified-attn-d64-bf16-fp8-kvsplit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
269b428
perf: length-aware KV split for gfx950 head-dim-64 bf16-Q / fp8-KV un…
yuychang 0f679c9
test: cover the length-aware KV split and long-KV head-dim-64 bf16-Q …
yuychang 6be8513
fix: keep calls outside the length-aware KV split on the uniform split
yuychang 892b833
Merge branch 'main' into k3/unified-attn-d64-bf16-fp8-kvsplit
yuychang 9dc56e1
[Triton] Fix unified attention split scope and config placement
yuychang 1e1e744
Merge branch 'main' into k3/unified-attn-d64-bf16-fp8-kvsplit
yuychang 00b100c
fix: read int64 sequence lengths in the length-aware KV split
yuychang 8f918d8
fix: guard the length-aware split's packed counts and config keys
yuychang aa932a6
perf: shorten the length-aware item run for small batches
yuychang 1508e18
test: replay the length-aware split from a CUDA graph with changing l…
yuychang 967e2c4
test: share the per-request relative L2 check in test_unified_attention
yuychang 9822c70
Merge branch 'main' into k3/unified-attn-d64-bf16-fp8-kvsplit
yuychang 90c580c
fix: bound per-sequence tile rounding in the length-aware split guard
yuychang 2c1fcd5
perf: size the length-aware grid to split_budget + num_seqs - 1 work …
yuychang a207dce
Merge branch 'main' into k3/unified-attn-d64-bf16-fp8-kvsplit
yuychang 34517cb
fix: skip length-aware KV split when sliding window is on
yuychang 642e0af
test: check the length-aware split stays off under a sliding window
yuychang a121bf8
perf: size the length-aware 3D block to the query rows
yuychang b6997bd
test: check the length-aware query-block guard on verify params
yuychang acd39a1
fix: harden the length-aware KV split's item lookup and scope
yuychang ede8629
docs: shorten the length-aware KV split comments to two sentences
yuychang d8b4be4
docs: shorten the length-aware launch comment to two sentences
yuychang 2be2fe4
Merge branch 'main' into k3/unified-attn-d64-bf16-fp8-kvsplit
yuychang ca444d6
fix: merge no segments for a zero-length sequence in the length-aware…
yuychang 0688eb5
fix: keep the uniform split when a length-aware config key is missing
yuychang 4613ba2
test: cover shuffled KV, softcap and qq_bias on the length-aware split
yuychang a68a426
test: size the length-aware split KV cache by the pages in use
yuychang 9d14449
Merge branch 'main' into k3/unified-attn-d64-bf16-fp8-kvsplit
yuychang 876b641
docs(test): cut the _length_aware_pages docstring to two sentences
yuychang 4efe461
test: run the length-aware split and long-KV unified_attention tests …
yuychang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.