Skip to content

[Triton/Gluon] feat(attention): expose paged backend arch support - #7026

Merged
valarLip merged 1 commit into
mainfrom
xiaobingsuper/pa-backend-arch-support
Oct 27, 2026
Merged

valarLip merged 1 commit into
mainfrom
xiaobingsuper/pa-backend-arch-support

Conversation

@XiaobingSuper

@XiaobingSuper XiaobingSuper commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Expose backend-owned architecture capability queries next to their implementations:

  • pa_decode_gluon_supports_arch() in aiter.ops.triton.gluon.pa_decode_gluon
  • pa_fwd_asm_supports_arch() in aiter.ops.attention

This lets callers route around unavailable backends without duplicating aiter's supported-architecture knowledge. Each query stays with the backend whose capability it reports; the Gluon query reuses its existing get_cdna_version() source of truth. It addresses the review request on ROCm/ATOM#2710 to keep these checks in aiter.

Validation

  • Python compileall: passed
  • Ruff: passed
  • Black: passed

No kernel implementation or dispatch behavior is changed.

@XiaobingSuper
XiaobingSuper requested review from a team and a balanced review from Copilot October 27, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs (added automatically when gfx942 configs change); main branch always runs both MI35X and MI300X
ci:triton-355 Run the full Triton test suite on MI35X, not only the tests the change affects
ci:windows Windows JIT op smoke test on the gfx1201 ROCm runner
ci:multi-gpu Aiter multi-GPU tests on the 8-GPU runner
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: DeepSeek-V4-Pro, MiniMax-M3-MXFP4
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 7026 --add-label <label>

One backend per PR:
A PR changes one kernel backend: [Triton/Gluon] (Triton and Gluon count as one), [HIP], [ASM], [CK], [OPUS] or [FlyDSL]. If the title ends up with two backend tags, split the PR -- as stacked pull requests when one part cannot merge without the other.

PR title tags & labels:
Component tags ([Triton/Gluon], [HIP], [CK], [ASM], ...) are added to the PR title and as PR labels automatically from the changed files and re-synced on every push — change-type tags like [fix]/[Perf], op tags like [MLA], and human labels (ci:*) are left untouched. Add the no-auto-title label to stop the title rewrites; labels stay in sync either way.

@github-actions github-actions Bot changed the title feat(attention): expose paged backend arch support [Triton/Gluon] feat(attention): expose paged backend arch support Oct 27, 2026
@XiaobingSuper
XiaobingSuper force-pushed the xiaobingsuper/pa-backend-arch-support branch from a34a948 to 5d0c330 Compare October 27, 2026 14:30
Copilot AI balanced review requested due to automatic review settings October 27, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions github-actions Bot changed the title [Triton/Gluon] feat(attention): expose paged backend arch support feat(attention): expose paged backend arch support Oct 27, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@XiaobingSuper
XiaobingSuper force-pushed the xiaobingsuper/pa-backend-arch-support branch from 5d0c330 to f212645 Compare October 27, 2026 14:32
Copilot AI balanced review requested due to automatic review settings October 27, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions github-actions Bot changed the title feat(attention): expose paged backend arch support [Triton/Gluon] feat(attention): expose paged backend arch support Oct 27, 2026
@valarLip
valarLip merged commit b3afbfa into main Oct 27, 2026
45 of 46 checks passed
@valarLip
valarLip deleted the xiaobingsuper/pa-backend-arch-support branch October 27, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants