Repository navigation
Conversation
…f_t intrinsics fix, rocm-libraries#13071)
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
One backend per PR: PR title tags & labels: |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The broad CK upgrade requires expanded documentation and regression validation beyond the two stated fixes.
Review effort: Balanced
Findings: None
What changed in this PR
Repins CK to a fetchable upstream commit, but also incorporates 132 CK commits rather than only the two described fixes.
Changes:
- Updates the CK submodule revision.
- Restores upstream Relu2 and
half_tfixes.
| File | Description |
|---|---|
3rdparty/composable_kernel |
Advances the CK submodule pin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@yzhou103: Could one of you review this ?. It repins 3rdparty/composable_kernel from the last-known-good commit to 96afae1d54fc79c26857de7e1683b0dde1ff3c6f on CK's develop branch, now that the two orphaned commits (MoeRelu2 functor + gfx950 half_t intrinsics fix) have been properly upstreamed and merged via rocm-libraries#13071. |
|
@valarLip : Can you please review at your convenient time ? |
Motivation
Repins the
3rdparty/composable_kernelsubmodule to a valid, fetchable upstream commit, fixing the CI submodule-sync breakage that led to #6142 reverting #5708.Technical Details
#5708 originally pinned
3rdparty/composable_kernelto1f66d862231703a0f354e5771e58573139bb6efb— a commit that existed only in a local CK checkout, never pushed to any branch onROCm/composable_kernel. This made the pin unfetchable and broke CI's submodule sync, so #6142 reverted it back to the last-known-good pin,af9e1d1f1ae347c22feeb08fd2d42645075e0c5d.The two commits that were stacked on the bad pin (
Add MoeRelu2 activation functor for gate-only MoE flatmm kernelandFix half_t intrinsics (neg/sin/exp/log) via float round-trip for gfx950) have since been properly submitted and merged upstream via ROCm/rocm-libraries#13071, landing on CK'sdevelopbranch at commit96afae1d54fc79c26857de7e1683b0dde1ff3c6f.This PR repins
3rdparty/composable_kernelfromaf9e1d1f1ae347c22feeb08fd2d42645075e0c5dto96afae1d54fc79c26857de7e1683b0dde1ff3c6f.Note on scope (updated after review feedback): this repin advances the submodule to the current tip of CK's
developbranch, not a hand-picked commit isolating only the two fixes above. Sincedevelopis a shared branch, the pin advance necessarily carries 132 other commits that landed upstream between the old pin (af9e1d1f) and now — build/CI changes, gfx1250 enablement, FMHA performance tuning, dependency bumps, docs, etc. — none of which touch MoE/relu2/half_t code. This is standard/expected behavior for a submodule bump against a tracked branch (there is no way to cherry-pick just two commits onto the old base and still call it "develop"). No functional changes to aiter's own source are introduced by this PR itself — only the submodule pointer.Test Plan
96afae1d54fc79c26857de7e1683b0dde1ff3c6f) is reachable viagit fetch originagainstROCm/composable_kerneland resolves cleanly withgit checkout.git submodule statusreports a clean, non-dirty pin after the update (no+/-prefix indicating divergence).git log --oneline af9e1d1f1ae347c22feeb08fd2d42645075e0c5d..96afae1d54fc79c26857de7e1683b0dde1ff3c6fthat the 132 intervening commits are all unrelated upstream CK work (gfx1250 enablement, FMHA perf, build/CI, dependency bumps) with no overlap with MoE/relu2/half_t code paths.Test Result
git submodule status 3rdparty/composable_kernelafter this change reports:with no dirty/divergence marker — the pin is clean and fetchable.
git log --oneline af9e1d1f1ae..96afae1d54f | wc -l→132commits, all confirmed unrelated to MoE/relu2/half_t.Submission Checklist