Skip to content

[Triton/Gluon] enable TDM fusion on MXFP4 - #6097

Merged
Boss2002n merged 1 commit into
mainfrom
satya/mxfp4_improvements
Oct 2, 2026
Merged

Boss2002n merged 1 commit into
mainfrom
satya/mxfp4_improvements

Conversation

@Boss2002n

@Boss2002n Boss2002n commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Move all descriptors before the four copies then the compiler fuses all TDM copies
o_proj went from 52.45 to 45.2 us in DSR1

@Boss2002n
Boss2002n requested review from a team and a balanced review from Copilot October 2, 2026 14:37
@Boss2002n Boss2002n self-assigned this Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs (added automatically when gfx942 configs change); main branch always runs both MI35X and MI300X
ci:triton-355 Run the full Triton test suite on MI35X, not only the tests the change affects
multigpu Aiter multi-GPU tests on the 8-GPU runner
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 6097 --add-label <label>

One backend per PR:
A PR changes one kernel backend: [Triton/Gluon] (Triton and Gluon count as one), [HIP], [ASM], [CK], [OPUS] or [FlyDSL]. If the title ends up with two backend tags, split the PR -- as stacked pull requests when one part cannot merge without the other.

PR title tags & labels:
Component tags ([Triton/Gluon], [HIP], [CK], [ASM], ...) are added to the PR title and as PR labels automatically from the changed files and re-synced on every push — change-type tags like [fix]/[Perf], op tags like [MLA], and human labels (ci:*) are left untouched. Add the no-auto-title label to stop the title rewrites; labels stay in sync either way.

@github-actions github-actions Bot changed the title enable TDM fusion on MXFP4 [Triton/Gluon] enable TDM fusion on MXFP4 Oct 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The unrelated output-layout change should be separated, and the new comment contains a typo.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Updates the gfx1250 MXFP4 Gluon GEMM to enable fusion of staged TDM loads.

Changes:

  • Groups descriptor updates before four asynchronous TDM loads.
  • Adjusts wait counts for fused operations.
  • Changes the output staging layout.
File Description
aiter/​ops/​triton/​_gluon_kernels/​gfx1250/​gemm/​basic/​gemm_mxfp4.py Refactors TDM staging and synchronization for load fusion.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread aiter/ops/triton/_gluon_kernels/gfx1250/gemm/basic/gemm_mxfp4.py
Comment thread aiter/ops/triton/_gluon_kernels/gfx1250/gemm/basic/gemm_mxfp4.py
@Boss2002n
Boss2002n merged commit c847570 into main Oct 2, 2026
61 of 63 checks passed
@Boss2002n
Boss2002n deleted the satya/mxfp4_improvements branch October 2, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants