Skip to content

[Triton/Gluon] Skip MXFP4 logits tests on unsupported GPUs - #5958

Merged
azaidy merged 1 commit into
mainfrom
bmazzott/fix-triton-gfx942-tests
Oct 1, 2026
Merged

azaidy merged 1 commit into
mainfrom
bmazzott/fix-triton-gfx942-tests

Conversation

@brunomazzottiamd

@brunomazzottiamd brunomazzottiamd commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

The following tests fail on gfx942 due to lack of MXFP4 support:

  • op_tests/triton_tests/attention/test_pa_mqa_logits_mxfp4.py
  • op_tests/triton_tests/rope/test_rope_mxfp4.py

The respective implementations require gfx950 architecture with assertions:

# Gluon kernel for gfx950 only for now
assert arch_info.get_arch() == "gfx950", "gfx950 only"

Technical Details

This PR skips MXFP4 logits tests on unsupported GPUs (GPUs other than gfx950 at the moment of writing).

Test Plan

Run the affected tests, thought AITER CI, in gfx942 in gfx950. No failures are expected.

Test Result

Affected tests passing in both gfx942 and gfx950. ✅

Submission Checklist

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs (added automatically when gfx942 configs change); main branch always runs both MI35X and MI300X
ci:triton-355 Run the full Triton test suite on MI35X, not only the tests the change affects
multigpu Aiter multi-GPU tests on the 8-GPU runner
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 5958 --add-label <label>

One backend per PR:
A PR changes one kernel backend: [Triton/Gluon] (Triton and Gluon count as one), [HIP], [ASM], [CK], [OPUS] or [FlyDSL]. If the title ends up with two backend tags, split the PR -- as stacked pull requests when one part cannot merge without the other.

PR title tags & labels:
Component tags ([Triton/Gluon], [HIP], [CK], [ASM], ...) are added to the PR title and as PR labels automatically from the changed files and re-synced on every push — change-type tags like [fix]/[Perf], op tags like [MLA], and human labels (ci:*) are left untouched. Add the no-auto-title label to stop the title rewrites; labels stay in sync either way.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The skip conditions match the implementation’s explicit gfx950 restriction.

Review effort: Balanced
Findings: None

What changed in this PR

Skips gfx950-only MXFP4 logits tests on unsupported GPU architectures.

Changes:

  • Adds architecture-based skipping for the MXFP4 attention test suite.
  • Skips the rope/logits round-trip test outside gfx950.
File Description
op_tests/​triton_tests/​rope/​test_rope_mxfp4.py Gates the logits round-trip test on gfx950.
op_tests/​triton_tests/​attention/​test_pa_mqa_logits_mxfp4.py Gates the MXFP4 logits test module on gfx950.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@azaidy azaidy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azaidy
azaidy merged commit 0178bd3 into main Oct 1, 2026
77 checks passed
@azaidy
azaidy deleted the bmazzott/fix-triton-gfx942-tests branch October 1, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants