Repository navigation
[Triton/Gluon] Skip MXFP4 logits tests on unsupported GPUs - #5958
Conversation
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
One backend per PR: PR title tags & labels: |
e538645 to
d0326db
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The skip conditions match the implementation’s explicit gfx950 restriction.
Review effort: Balanced
Findings: None
What changed in this PR
Skips gfx950-only MXFP4 logits tests on unsupported GPU architectures.
Changes:
- Adds architecture-based skipping for the MXFP4 attention test suite.
- Skips the rope/logits round-trip test outside gfx950.
| File | Description |
|---|---|
op_tests/triton_tests/rope/test_rope_mxfp4.py |
Gates the logits round-trip test on gfx950. |
op_tests/triton_tests/attention/test_pa_mqa_logits_mxfp4.py |
Gates the MXFP4 logits test module on gfx950. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
d0326db to
45cf630
Compare
Motivation
The following tests fail on
gfx942due to lack of MXFP4 support:op_tests/triton_tests/attention/test_pa_mqa_logits_mxfp4.pyop_tests/triton_tests/rope/test_rope_mxfp4.pyThe respective implementations require
gfx950architecture with assertions:Technical Details
This PR skips MXFP4 logits tests on unsupported GPUs (GPUs other than
gfx950at the moment of writing).Test Plan
Run the affected tests, thought AITER CI, in
gfx942ingfx950. No failures are expected.Test Result
Affected tests passing in both
gfx942andgfx950. ✅Submission Checklist