Skip to content

[Triton/Gluon] stop fused_bmm_rope_kv_cache from using batched_gemm_a8w8_a_per_token… #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azaidy merged 1 commit into from
Sep 29, 2026
Merged

[Triton/Gluon] stop fused_bmm_rope_kv_cache from using batched_gemm_a8w8_a_per_token… #5877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions aiter/ops/triton/_triton_kernels/fusions/fused_bmm_rope_kv_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from aiter.ops.triton.rope.rope import _get_gptj_rotated_x_1D, _get_neox_rotated_x_1D
from aiter.ops.triton.utils._triton.kernel_repr import make_kernel_repr
from aiter.ops.triton.utils._triton.pid_preprocessing import pid_grid
from aiter.ops.triton.utils.gemm_config_utils import get_gemm_config

_fused_fp4_bmm_rope_cat_and_cache_mla_repr = make_kernel_repr(
"_fused_fp4_bmm_rope_cat_and_cache_mla_kernel",
Expand Down Expand Up @@ -1035,3 +1036,18 @@ def _fused_fp8_bmm_rope_cat_and_cache_mla_kernel(
kv_cache_ptrs + (d_pe_offs + BLOCK_DK_nope) * kv_cache_stride_d,
k_pe_scaled,
)


def _get_fp8_config(
M: int,
N: int,
K: int,
):
# Own config family: the fused BMM + RoPE grid prefers different tiles
# than the standalone batched_gemm_a8w8 prequant kernel.
return get_gemm_config(
"FUSED-FP8-BMM-ROPE-CAT-AND-CACHE-MLA",
M,
N,
K,
)
68 changes: 68 additions & 0 deletions .../ops/triton/configs/gfx1201/triton/gemm/fused_fp8_bmm_rope_cat_and_cache_mla/DEFAULT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"M_LEQ_16": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 32,
"GROUP_SIZE_M": 1,
"num_warps": 4,
"num_stages": 2,
"waves_per_eu": 6,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_32": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 64,
"GROUP_SIZE_M": 8,
"num_warps": 4,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_64": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 8,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_128": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 256,
"GROUP_SIZE_M": 8,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 4,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_256": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 256,
"GROUP_SIZE_M": 8,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"any": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 256,
"GROUP_SIZE_M": 8,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": null,
"kpack": 1
}
}
68 changes: 68 additions & 0 deletions ...used_fp8_bmm_rope_cat_and_cache_mla/FUSED-FP8-BMM-ROPE-CAT-AND-CACHE-MLA-N=128-K=512.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"M_LEQ_16": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 2,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_32": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_64": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_128": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_256": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"any": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 1,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
}
}
68 changes: 68 additions & 0 deletions ...used_fp8_bmm_rope_cat_and_cache_mla/FUSED-FP8-BMM-ROPE-CAT-AND-CACHE-MLA-N=512-K=128.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"M_LEQ_16": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 32,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 1,
"waves_per_eu": 6,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_32": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 8,
"num_warps": 8,
"num_stages": 1,
"waves_per_eu": 8,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_64": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 4,
"num_warps": 8,
"num_stages": 1,
"waves_per_eu": 4,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"M_LEQ_128": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 4,
"num_warps": 8,
"num_stages": 1,
"waves_per_eu": 4,
"matrix_instr_nonkdim": 16,
"cache_modifier": null,
"kpack": 1
},
"M_LEQ_256": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 4,
"num_warps": 8,
"num_stages": 1,
"waves_per_eu": 4,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
},
"any": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 256,
"GROUP_SIZE_M": 4,
"num_warps": 8,
"num_stages": 1,
"waves_per_eu": 4,
"matrix_instr_nonkdim": 16,
"cache_modifier": ".cg",
"kpack": 1
}
}
68 changes: 68 additions & 0 deletions .../ops/triton/configs/gfx1250/triton/gemm/fused_fp8_bmm_rope_cat_and_cache_mla/DEFAULT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"M_LEQ_16": {
"BLOCK_SIZE_M": 16,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 2,
"matrix_instr_nonkdim": 16,
"kpack": 1,
"cache_modifier": ".cg"
},
"M_LEQ_32": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 2,
"matrix_instr_nonkdim": 16,
"kpack": 1,
"cache_modifier": ".cg"
},
"M_LEQ_64": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 2,
"matrix_instr_nonkdim": 16,
"kpack": 1,
"cache_modifier": ".cg"
},
"M_LEQ_128": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 2,
"matrix_instr_nonkdim": 16,
"kpack": 1,
"cache_modifier": ".cg"
},
"M_LEQ_256": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 2,
"matrix_instr_nonkdim": 16,
"kpack": 1,
"cache_modifier": ".cg"
},
"any": {
"BLOCK_SIZE_M": 32,
"BLOCK_SIZE_N": 128,
"GROUP_SIZE_M": 1,
"num_warps": 8,
"num_stages": 2,
"waves_per_eu": 2,
"matrix_instr_nonkdim": 16,
"kpack": 1,
"cache_modifier": ".cg"
}
}
Loading
Loading