Repository navigation
[Config] Restore accurate Kimi-K3 A4W4 FMoE decode tiles - #5756
amd-mghanimi wants to merge 1 commit into
Conversation
Swap the high-error mxmoe rows (tokens 1,2,4,8,16,32,64,8192) back to the prior moe1 kernels so NIAH decode accuracy recovers without dropping the rest of the tuned table. Signed-off-by: Mehdi Ghanimifard <mehdi.ghanimifard@amd.com>
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The change alters runtime kernel selection for accuracy-critical decode shapes and needs the stated NIAH validation run to confirm the expected quality recovery.
Review effort: Lite
Findings: None
What changed in this PR
Restores previously accurate FlyDSL MoE decode-tile kernel selections for the Kimi-K3 A4W4 expert-FMoE configuration by reverting a subset of high-error rows from flydsl_mxmoe back to the older flydsl_moe1 choices.
Changes:
- Replaced
flydsl_mxmoestage1 kernel selections withflydsl_moe1for the expert-FMoE decode token buckets 1, 2, 4, 8, 16, 32, 64, and 8192. - Updated associated stage2
flydsl_moe2_layout_*kernels and timing/error metadata for those rows while leaving other rows unchanged.
| File | Description |
|---|---|
| aiter/configs/model_configs/kimik3_a4w4_tuned_fmoe.csv | Reverts 8 high-error decode rows back to moe1-based tiles to recover Kimi-K3 A4W4 NIAH accuracy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
kimik3_a4w4_tuned_fmoe.csvdecode tiles switched fromflydsl_moe1(~0.1% tune err) toflydsl_mxmoe(~1.1–2.1% err, plus cosine ~0.011 on token=1/2). Those rows landed in [HIP] [CK] [FlyDSL] [Kernel] Extend MXFP4 GEMM1 replacement to A4W4 #4526 (fe4814c64).limit=50, C=32): baseline 0.82 → 0.94–0.96. This PR restores only the 8 high-err expert-FMoE rows (token1,2,4,8,16,32,64,8192) and leaves the remaining moe1 tiles and shared-expert rows unchanged.token=4096was already moe1 and is untouched. Decode tiles are what NIAH hits.Test plan
niah_single_2at 4k (limit=50, C=32); expect ~0.92–0.96 vs 0.82 on the mxmoe tabletoken3,128–4096,16384,32768 andinter_dim=3072shared-expert rows) still select the current kernelsMade with Cursor