Repository navigation
[ASM] [CI] Remove committed scratch files and stop two from coming back - #5544
Conversation
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
Six tracked files that nothing reads and nothing will read again, plus the workflow fix that stops two of them returning. CI scratch the bot committed. update-split-tests.yaml wrote split-tests-update-summary.md and then pr-body.md into the workspace and handed them to peter-evans/create-pull-request, which commits every new and modified file when add-paths is unset. Both reached the repo root that way in #5131, and the tracked copies were stale the moment they landed because the workflow regenerates them on every run. The job only ever means to change one file, so add-paths now names .github/scripts/split_tests.sh, and both scratch files move to the runner temp directory so they are never dirty workspace files in the first place. The .gitignore entries remain as a backstop for local runs, where --summary-path still defaults to the working directory. Merge and POC leftovers that ship in the wheel. hsa/gfx950/pa/pa_bf16_noquant_gqa8_1tg_4w.co.orig and .co.poc_kl_merg arrived with #3211 next to the real .co. Nothing references either by name, and the ASM loaders build .co paths explicitly rather than globbing the directory, so neither is reachable. They are not merely inert: setup.py copies all of hsa/ into aiter_meta and MANIFEST.in grafts it, so 48 KB of scratch binaries go out in every wheel. *.orig is now ignored so the next conflicted merge does not leave another one behind. One-off files their PRs forgot. probe_noqa_check.py is a single line, x = 1, added in #4403 to confirm the pinned ruff config flagged it. REPO_CLEANUP_PLAN.md is a pull request description from #2167 in March. Its Phase 1 shipped -- the .pt test data is gone from main and the size rules are in .gitignore -- and its Phase 2 history rewrite needs a coordinated force push that has not happened in the six months since. Neither file is referenced anywhere in the tree. Left alone: scripts/download_test_data.sh, a no-op stub from that same plan, because docs/tutorials/index.rst still points readers at it. Retiring the script and the doc together is a separate change.
There was a problem hiding this comment.
🟢 Approval recommended
The only noted issue is a non-blocking documentation nit.
Pull request overview
Removes stale CI artifacts and unreferenced scratch files while preventing them from being recommitted.
Changes:
- Deletes obsolete generated files, documentation, probe code, and binaries.
- Adds
.gitignorerules for CI outputs and merge backups.
File summaries
| File | Summary |
|---|---|
split-tests-update-summary.md |
Removes stale CI output. |
REPO_CLEANUP_PLAN.md |
Removes obsolete cleanup documentation. |
probe_noqa_check.py |
Removes one-off lint probe. |
pr-body.md |
Removes generated PR body. |
.gitignore |
Adds ignore rules; nit: update the inaccurate add-paths comment or configure the workflow input. |
Review details
- Files reviewed: 4/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
6916bc8 to
df00de2
Compare
ROCm/aiter PR #5544 — [ASM] [CI] Remove committed scratch files and stop two from coming backDeletes six unreferenced scratch files (two CI-generated markdown at the repo root, two leftover gfx950 code objects, a one-line ruff probe, a stale cleanup plan) and stops the CI bot from recommitting its scratch by redirecting workflow output to the runner temp dir and constraining what the bot may commit to split_tests.sh. Review (advisory): ✅ NO FINDINGS |
Two modify/delete conflicts, pr-body.md and split-tests-update-summary.md: #5713 regenerated both in the repo root, which is the behaviour this branch removes. Resolved as deletions. The same branch fixes the cause -- the update-split-tests job now writes them under RUNNER_TEMP and passes add-paths so create-pull-request commits only split_tests.sh -- so #5713 is the last run that could have put them back. #5713's refreshed FILE_TIMES table in split_tests.sh merged cleanly and is kept; only the two scratch files it also committed are removed.
gyohuangxin
left a comment
There was a problem hiding this comment.
Thanks for the improvement. But could you explain the reason to delete REPO_CLEANUP_PLAN.md ?
@zufayu can you also check the deletion of probe_noqa_check.py and has/gfx950/pa/*** ?
Its a PR description file - that PR has been merged - rendering this md file moot |
|
let me check We generally need to be very careful when deleting files. |
|
Thanks for the clarification. I checked the remaining deletions:
Those deletions look safe.
|
Repo size: Phase 2 of REPO_CLEANUP_PLAN.md, retargetedPhase 1 (from #2167) shipped and is live. Phase 2 never ran — but measuring it first shows the plan aims at the wrong target. Phase 1: done, in place on
|
-- | --
.gitignore lines 65–78 | *.pt, *.pth, *.ckpt, op_tests/test_jenga_vsa/, op_tests/dump_data/, OUT_FOLDER/, *.att
.githooks/pre-commit, .githooks/install | present
scripts/download_test_data.sh | present
|
|
Thanks, this answers my question. Phase 1 is complete, and the original Phase 2 history rewrite was never run and is no longer the plan. Please link the branch-archive tracking issue or PR once it is created, so that follow-up is not lost when |
Done |
|
@Boss2002n Is this just a cleanup PR? |
yes |
brunomazzottiamd
left a comment
There was a problem hiding this comment.
@Boss2002n, I think we have the green light to merge from CI team, given all the PR discussions. Am I right?
@gyohuangxin / @zufayu can you please get back to this PR and double check if all discussions are addressed according to your requests? Thanks!
Six tracked files that nothing reads and nothing will read again.
CI scratch committed by the bot. update-split-tests.yaml writes split-tests-update-summary.md and then pr-body.md into the workspace and hands them to peter-evans/create-pull-request, which has no add-paths filter and so commits every dirty file it finds. Both landed in the repo root that way in #5131. The workflow regenerates them on every run, so the tracked copies are stale by definition; .gitignore now keeps the bot from re-adding them.
Merge and POC leftovers that ship in the wheel.
hsa/gfx950/pa/pa_bf16_noquant_gqa8_1tg_4w.co.orig and .co.poc_kl_merg arrived with #3211 next to the real .co. Nothing references either by name, and the ASM loaders build .co paths explicitly rather than globbing the directory, so neither is reachable. They are not merely inert: setup.py copies all of hsa/ into aiter_meta and MANIFEST.in grafts it, so 48 KB of scratch binaries go out in every wheel. *.orig is now ignored so the next conflicted merge does not leave another one behind.
One-off files their PRs forgot. probe_noqa_check.py is a single line, x = 1, added in #4403 to confirm the pinned ruff config flagged it. REPO_CLEANUP_PLAN.md is a pull request description from #2167 in March. Its Phase 1 shipped -- the .pt test data is gone from main and the size rules are in .gitignore -- and its Phase 2 history rewrite needs a coordinated force push that has not happened in the six months since. Neither file is referenced anywhere in the tree.