Fix stale TopK availability checks - #5210
Merged
coderfeli merged 1 commit intoSep 2, 2026
Merged
Conversation
FlyDSL is required after ROCm#5116, so the removed helper breaks test collection and silently disables decode dispatch. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
coderfeli
approved these changes
Sep 2, 2026
Fyzyukk
pushed a commit
to Fyzyukk/aiter
that referenced
this pull request
Sep 3, 2026
FlyDSL is required after ROCm#5116, so the removed helper breaks test collection and silently disables decode dispatch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiter.ops.flydsl.utilsmoduleop_tests/test_topk_per_row.pycollection in the standard-test suiteContext
#5116 removed the optional FlyDSL availability helper and made FlyDSL imports unconditional. #5011 landed later with two references to the removed helper:
ModuleNotFoundErrorThis was observed in the MI35X standard-test failure on #4761. The failure occurs before any GPU kernel executes.
Test plan
PYTHONPYCACHEPREFIX=/tmp/aiter-topk-fix-pycache python3 -m py_compile aiter/ops/topk.py op_tests/test_topk_per_row.pygit diff --checkaiter.ops.flydsl.utilsoris_flydsl_availableremainMade with Cursor