[CI] Run extended test dispatch on internal runner - #5205
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
There was a problem hiding this comment.
🟡 Changes recommended
The workflow now runs a dispatch-only job on an MI250 self-hosted runner, which can unnecessarily consume GPU runner capacity and impact CI throughput.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
3bb1fd1 to
8400060
Compare
8400060 to
a80f390
Compare
a80f390 to
9efad15
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Moving the long-polling “wait for status” loop onto the internal MI250 runner can unnecessarily tie up scarce self-hosted capacity for up to ~180 minutes per run.
Review details
Suppressed comments (1)
.github/workflows/extended-test.yaml:33
- Switching this job to the internal
linux-aiter-build-mi250runner will now keep that self-hosted runner occupied for up toEXTENDED_TEST_WAIT_TIMEOUT_MINUTES(default 180) due to the polling loop in “Wait for extended test result” (sleeping/retrying every 30s). Since this job mostly performs GitHub API calls, consider splitting into two jobs: (1) a short dispatch job on the internal runner, and (2) a separate wait/poll job on a GitHub-hosted runner thatneeds:the dispatch job. This avoids tying up scarce MI250 capacity for hours waiting on external status.
contains(github.event.pull_request.labels.*.name, 'ci:extended-test')
) &&
(github.event.action != 'labeled' || github.event.label.name == 'ci:extended-test')
runs-on: linux-aiter-build-mi250
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Update the Extended Test dispatch job to run on the internal linux-aiter-build-mi250 runner instead of GitHub hosted ubuntu-latest. This lets the dispatch call reach the private AMD-ROCm-Internal/fw-bringup repository from an allowed network path.