Skip to content

[CI] CI: respect docker login input in release builds - #5201

Merged
gyohuangxin merged 1 commit into
mainfrom
ci/fix-release-docker-login
Sep 2, 2026
Merged

gyohuangxin merged 1 commit into
mainfrom
ci/fix-release-docker-login

Conversation

@gyohuangxin

Copy link
Copy Markdown
Member

Summary

  • Add an explicit docker_login input to the direct Aiter Release Package manual workflow.
  • Stop treating every workflow_dispatch event as an implicit Docker login request.
  • Only configure Docker Hub secret names and run Docker login when inputs.docker_login is true.

This fixes release automation manual runs where the caller passes docker_login: false, but the reusable workflow previously converted it back to true because the caller event was workflow_dispatch.

Test plan

  • python3 -c "import yaml; yaml.safe_load(open('.github/workflows/aiter-release.yaml')); print('yaml ok')"
  • git diff --check

@gyohuangxin
gyohuangxin requested review from a team and a lite review from Copilot September 2, 2026 03:42
@github-actions github-actions Bot changed the title CI: respect docker login input in release builds [CI] CI: respect docker login input in release builds Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
multigpu Aiter multi-GPU tests on the 8-GPU runner
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 5201 --add-label <label>

PR title tags & labels:
Component tags ([Triton/Gluon], [HIP], [CK], [ASM], ...) are added to the PR title and as PR labels automatically from the changed files and re-synced on every push — change-type tags like [fix]/[Perf], op tags like [MLA], and human labels (ci:*) are left untouched. Add the no-auto-title label to opt this PR out.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped to CI workflow expressions and correctly aligns Docker login behavior with the explicit docker_login input.

Pull request overview

This PR updates the release packaging GitHub Actions workflow to make Docker Hub login explicitly opt-in via a docker_login input, instead of implicitly enabling login on all workflow_dispatch runs.

Changes:

  • Added a docker_login boolean input to the manual (workflow_dispatch) trigger for aiter-release.yaml.
  • Removed the implicit “workflow_dispatch => docker login” behavior by keying Docker secret selection and DOCKER_LOGIN solely off inputs.docker_login.
File summaries
File Description
.github/workflows/aiter-release.yaml Adds explicit docker_login input and gates Docker secret selection/login behavior on that input only.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@gyohuangxin
gyohuangxin force-pushed the ci/fix-release-docker-login branch from e3d535b to 822f9ce Compare September 2, 2026 03:48
Copilot AI review requested due to automatic review settings September 2, 2026 03:48
@gyohuangxin
gyohuangxin merged commit cab9e49 into main Sep 2, 2026
39 checks passed
@gyohuangxin
gyohuangxin deleted the ci/fix-release-docker-login branch September 2, 2026 03:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow currently lacks a workflow_dispatch-scoped docker_login input, so manual runs cannot explicitly enable Docker login and the new gating will always evaluate false for dispatch runs.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment on lines +170 to +174
DOCKER_USERNAME_SECRET: ${{ inputs.docker_login && needs.ci_config.outputs.docker_username_secret || '' }}
DOCKER_PASSWORD_SECRET: ${{ inputs.docker_login && needs.ci_config.outputs.docker_password_secret || '' }}
BUILD_REF: ${{ inputs.commit || github.event.inputs.commit || '' }}
ARTIFACT_SUFFIX: ${{ inputs.artifact_suffix || '' }}
DOCKER_LOGIN: ${{ github.event_name == 'workflow_dispatch' || inputs.docker_login }}
DOCKER_LOGIN: ${{ inputs.docker_login }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants