[CI] CI: respect docker login input in release builds - #5201
Conversation
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags & labels: |
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to CI workflow expressions and correctly aligns Docker login behavior with the explicit docker_login input.
Pull request overview
This PR updates the release packaging GitHub Actions workflow to make Docker Hub login explicitly opt-in via a docker_login input, instead of implicitly enabling login on all workflow_dispatch runs.
Changes:
- Added a
docker_loginboolean input to the manual (workflow_dispatch) trigger foraiter-release.yaml. - Removed the implicit “
workflow_dispatch=> docker login” behavior by keying Docker secret selection andDOCKER_LOGINsolely offinputs.docker_login.
File summaries
| File | Description |
|---|---|
| .github/workflows/aiter-release.yaml | Adds explicit docker_login input and gates Docker secret selection/login behavior on that input only. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
e3d535b to
822f9ce
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The workflow currently lacks a workflow_dispatch-scoped docker_login input, so manual runs cannot explicitly enable Docker login and the new gating will always evaluate false for dispatch runs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
| DOCKER_USERNAME_SECRET: ${{ inputs.docker_login && needs.ci_config.outputs.docker_username_secret || '' }} | ||
| DOCKER_PASSWORD_SECRET: ${{ inputs.docker_login && needs.ci_config.outputs.docker_password_secret || '' }} | ||
| BUILD_REF: ${{ inputs.commit || github.event.inputs.commit || '' }} | ||
| ARTIFACT_SUFFIX: ${{ inputs.artifact_suffix || '' }} | ||
| DOCKER_LOGIN: ${{ github.event_name == 'workflow_dispatch' || inputs.docker_login }} | ||
| DOCKER_LOGIN: ${{ inputs.docker_login }} |
Summary
docker_logininput to the direct Aiter Release Package manual workflow.workflow_dispatchevent as an implicit Docker login request.inputs.docker_loginis true.This fixes release automation manual runs where the caller passes
docker_login: false, but the reusable workflow previously converted it back to true because the caller event wasworkflow_dispatch.Test plan