Skip to content

[fix][flydsl] fix oob scale descriptor in ptpc fp8 gemm - #4546

Merged
zejunchen-zejun merged 3 commits into
mainfrom
guanbao/fix_flydsl_ptpc_gemm
Aug 5, 2026
Merged

zejunchen-zejun merged 3 commits into
mainfrom
guanbao/fix_flydsl_ptpc_gemm

Conversation

@gbyu-amd

@gbyu-amd gbyu-amd commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@gbyu-amd
gbyu-amd requested a review from a team August 4, 2026 07:34
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 4546 --add-label <label>

@zejunchen-zejun

zejunchen-zejun commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Hi, @Zufa @solinzby @XiaobingSuper
Could you help review the PR?
Thank you

@solinzby1

Copy link
Copy Markdown
Contributor

Hi, @Zufa @solinzby @XiaobingSuper Could you help review the PR? Thank you
LGTM

@coderfeli
coderfeli requested a review from solinzby1 August 4, 2026 10:09
Comment thread aiter/ops/flydsl/kernels/preshuffle_gemm.py Outdated
@ganyi1996ppo
ganyi1996ppo force-pushed the guanbao/fix_flydsl_ptpc_gemm branch from aa4c383 to 662edd2 Compare August 4, 2026 10:17
@coderfeli

Copy link
Copy Markdown
Collaborator

LGTM

@zejunchen-zejun
zejunchen-zejun merged commit de9f1f8 into main Aug 5, 2026
42 checks passed
@zejunchen-zejun
zejunchen-zejun deleted the guanbao/fix_flydsl_ptpc_gemm branch August 5, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants